Enable "Event Generating Elements Should Be Instrumented" ESLint rule for more O11y Apps

[CoenWarmer]

Summary

This enables the ESLint rule that requires event generating UI elements to have a data-test-subj for more Observability apps.

Specifically:

• observability_ai_assistant
• observability_shared
• observability_onboarding
• profiling

In addition this also adds the EuiButtonIcon component as a component which needs a data-test-subj.

Effect

This PR will trigger the CI to create a commit that adds a data-test-subj value for these elements:

export const EVENT_GENERATING_ELEMENTS = [
  'EuiButton',
  'EuiButtonEmpty',
  'EuiButtonIcon',
  'EuiLink',
  'EuiFieldText',
  'EuiFieldSearch',
  'EuiFieldNumber',
  'EuiSelect',
  'EuiRadioGroup',
  'EuiTextArea',
];

to all plugins that the rule is active for, and don't have a value set yet.

Once the PR is merged, engineers working on all these plugins will see a warning in their IDE when no data-test-subj is set on any of the aforementioned elements. ESLint will also be able to 'fix' this by suggesting a value based on the plugin name, React component name, Eui element name and if present, the translated text content.

Elements that already have a data-test-subj will not be touched, and engineers can always adjust the suggestion that the rule autogenerates (either in your IDE or by commiting changes afterwards).

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[elasticmachine]

Pinging @elastic/apm-ui (Team:APM)

[yngrdyn]

APM changes and Oblt onboarding changes LGTM

[cauemarcondes]

Profiling changes LGTM

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: 1052a8e
• Interpreting CI Failures

Failed CI Steps

• Serverless Security Cypress Tests #9
• Serverless Security Cypress Tests #16
• Serverless Security Cypress Tests #16
• Serverless Security Investigations Cypress Tests #6

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	3.7MB	3.7MB	+503.0B
exploratoryView	200.7KB	200.9KB	+211.0B
infra	2.0MB	2.0MB	+1.1KB
observability	1.0MB	1.0MB	+460.0B
observabilityAIAssistant	180.7KB	180.8KB	+122.0B
observabilityOnboarding	293.6KB	295.0KB	+1.4KB
profiling	335.9KB	337.7KB	+1.8KB
synthetics	909.7KB	910.4KB	+653.0B
ux	166.0KB	166.0KB	+47.0B
total			+6.3KB

History

• 💔 Build #156341 failed cd2111b
• 💔 Build #156323 failed ca1f86e
• 💔 Build #156283 failed 96d2a68d590e290d03047bb7cbcc8507b28b2648
• 💔 Build #156270 failed fd7a1eb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jennypavlova]

Infra changes LGTM

[kdelemme]

LGTM

[mgiota]

LGTM!