-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless][Security Solution][Endpoint] Gate endpoint exceptions on rule details and API changes #165613
Merged
ashokaditya
merged 89 commits into
elastic:main
from
ashokaditya:task/dw-gate-endpoint-exceptions-via-serverless-pli-7223
Oct 2, 2023
Merged
[Serverless][Security Solution][Endpoint] Gate endpoint exceptions on rule details and API changes #165613
Changes from 70 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
126ce01
gate endpoint exceptions on rule details
ashokaditya 8f9bdd5
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 552db79
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya dc51dd2
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya f17fe19
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya e6a5e92
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 82a954e
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya c7fefb3
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 488fa8f
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 36a2165
add endpoint exceptions privileges to authz
ashokaditya 12dcc17
add endpoint exceptions validator
ashokaditya 088c76a
use endpoint exceptions validator in extensions
ashokaditya fa1e8eb
update initial authz state in test
ashokaditya bf9577b
Update authz.test.ts
ashokaditya c44774d
update error class for endpoint exceptions
ashokaditya 793f6e0
use list id const
ashokaditya c03a8ed
fix type imports
ashokaditya 99cb5f5
fix type import
ashokaditya bc87d99
show upsell page for exception details
ashokaditya 64a12ec
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya c30e77b
upselling page related capability
ashokaditya 95e5730
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 0dcf24d
Show upsell on endpoint exceptions tab
ashokaditya 637a7e2
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 52d0bc9
rename
ashokaditya 02eb0a2
only check capabilities and not app feature
ashokaditya 25f934c
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 4b5185e
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine dc4bb74
rename
ashokaditya 795cc0d
remove redundant method for now
ashokaditya 141ee49
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 0243ad9
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 43a18c5
fix merge duplicate imports
ashokaditya 72fdb54
fix privilege calculations for endpoint expections
ashokaditya 953a7db
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 41b6ac2
fix types
ashokaditya b2d94f9
unit tests for `getAuthorizationFromPrivileges`
ashokaditya 1c29f75
fix types
ashokaditya d8bf3ac
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya e271a74
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 3bf3ca7
add endpoint exceptions to endpoint complete
ashokaditya ca84a31
tidy up a bit
ashokaditya de4f2e2
fix typo
ashokaditya a9751c6
update codeowners file
ashokaditya a2e89bd
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 48c8179
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 6c47ed8
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
kibanamachine e8a2cd1
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 723e380
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
kibanamachine cc75585
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya d6098ba
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 2909e76
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 6c1dbb4
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya eb077cc
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 9fd8d5a
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya b7cbf12
cleanup
ashokaditya 4e6927b
Merge branch 'task/dw-gate-endpoint-exceptions-via-serverless-pli-722…
ashokaditya 8425f83
fix merge error
ashokaditya ff99429
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
kibanamachine a11c12e
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 324da8d
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 8f28467
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
kibanamachine 74cf71a
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 4d1e41d
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya f7af9fd
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 08edd3a
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya a1897c0
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya ec06876
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 6a1a811
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
kibanamachine 4552de0
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
kibanamachine 141a413
fix run time error
ashokaditya 688e767
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 76955d2
tidy up
ashokaditya fe11e51
show exceptions tab for sub feature role with read only permission
ashokaditya 7cffc0e
disable actions for sub feature role
ashokaditya 080c60e
disable edit/delete on rule details tabs
ashokaditya 6e3a96c
unify capability check logic in a hook
ashokaditya 94d78dd
move file
ashokaditya f5728bd
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 35d0a11
refactor
ashokaditya 71050df
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 864e4ed
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 6ea0aaf
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 67cfaf1
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya 3a8e9c2
fix type check error
ashokaditya 71f3a96
use defined const
ashokaditya 823d759
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya fdaf8bb
Merge branch 'main' into task/dw-gate-endpoint-exceptions-via-serverl…
ashokaditya c3eca1a
fix merge error
ashokaditya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to ask this before: but were fleet changes really necessary for the endpoint exceptions authz?
We normally only have to touch fleet authz for when one of our kibana privileges needs to be used in fleet to allow access to one of the APIs. (right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it was necessary to add this to fleet authz same as we did for endpoint package privileges, as privilege verification is done via fleetAuthz for all endpoint/exception_list artifact APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about that. We only run our privileges through fleet so that we can enable fleet APIs for kibana features controls that are applicable to endpoint management.
For endpoint exceptions, I don't think they need access to fleet APIs (ex. they don't support the "per policy" functionality), so it should all have been done from within Security Solution? (ex. that's how it works today, prior to RBAC being introduced for serverless).