[Observability AI Assistant] Return errorDoc instead of error in GetApmErrorDocument function response
#165588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:APM) |
CoenWarmer
added
the
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
CoenWarmer
added
v8.10.0
v8.11.0
backport:prev-minor
dgieselaar
reviewed
Sep 4, 2023
x-pack/plugins/apm/public/assistant_functions/get_apm_error_document.ts
Outdated
Show resolved
Hide resolved
dgieselaar
reviewed
Sep 4, 2023
x-pack/plugins/apm/server/routes/assistant_functions/get_apm_error_document/index.ts
Show resolved
Hide resolved
CoenWarmer
force-pushed
the
bug/error-key-in-apm-error-doc
branch
from
2eaef8f to
b20a6a9
Compare
CoenWarmer
changed the title
errorDoc instead of error in GetApmErrorDocument functionerrorDoc instead of error in GetApmErrorDocument function response
CoenWarmer
force-pushed
the
bug/error-key-in-apm-error-doc
branch
from
b20a6a9 to
fc33aae
Compare
dgieselaar
approved these changes
Sep 4, 2023
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 4, 2023
…GetApmErrorDocument function (elastic#165588) (cherry picked from commit 046cfc8)
kibanamachine
added a commit
that referenced
this pull request
Sep 4, 2023
…or` in GetApmErrorDocument function (#165588) (#165601) # Backport This will backport the following commits from `main` to `8.10`: - [[Observability AI Assistant] Return `errorDoc` instead of `error` in GetApmErrorDocument function (#165588)](#165588) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Coen Warmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-04T13:49:48Z","message":"[Observability AI Assistant] Return `errorDoc` instead of `error` in GetApmErrorDocument function (#165588)","sha":"046cfc854dfbcf946d775c8f204b0a2c74414cd6","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","backport:prev-minor","v8.10.0","v8.11.0"],"number":165588,"url":"https://github.com/elastic/kibana/pull/165588","mergeCommit":{"message":"[Observability AI Assistant] Return `errorDoc` instead of `error` in GetApmErrorDocument function (#165588)","sha":"046cfc854dfbcf946d775c8f204b0a2c74414cd6"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165588","number":165588,"mergeCommit":{"message":"[Observability AI Assistant] Return `errorDoc` instead of `error` in GetApmErrorDocument function (#165588)","sha":"046cfc854dfbcf946d775c8f204b0a2c74414cd6"}}]}] BACKPORT--> Co-authored-by: Coen Warmer <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is done as the Assistant implementation assumes
errorindicates a faulty response and thus renders the return as if it were an error.