[Infra UI] Fix page content reload when date picker has relative dates #165462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
crespocarlos
commented
Sep 1, 2023
| @@ -104,7 +102,6 @@ export const LensWrapper = ({ | |||
| <div | |||
| css={css` | |||
| position: relative; | |||
| border-radius: ${euiTheme.size.s}; | |||
There was a problem hiding this comment.
There was a space between the triple dots button and the border
now:
then:
crespocarlos
added
Feature:Metrics UI
|
@elasticmachine merge upstream |
crespocarlos
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
jennypavlova
reviewed
Sep 4, 2023
| setEmbeddableLoaded(true); | ||
| } | ||
| }, [embeddableLoaded]); | ||
| const handlOnLoad = useCallback( |
There was a problem hiding this comment.
Should it be?
Suggested change
| const handlOnLoad = useCallback( | |
| const handleOnLoad = useCallback( |
Comment on lines
9
to
11
| import { TimeRange } from '@kbn/es-query'; | ||
| import { LensAttributes } from '@kbn/lens-embeddable-utils'; | ||
| import { LensEmbeddableInput, TypedLensByValueInput } from '@kbn/lens-plugin/public'; |
There was a problem hiding this comment.
Suggested change
| import { TimeRange } from '@kbn/es-query'; | |
| import { LensAttributes } from '@kbn/lens-embeddable-utils'; | |
| import { LensEmbeddableInput, TypedLensByValueInput } from '@kbn/lens-plugin/public'; | |
| import type { TimeRange } from '@kbn/es-query'; | |
| import type { LensAttributes } from '@kbn/lens-embeddable-utils'; | |
| import type { LensEmbeddableInput, TypedLensByValueInput } from '@kbn/lens-plugin/public'; |
| @@ -104,7 +102,6 @@ export const LensWrapper = ({ | |||
| <div | |||
| css={css` | |||
| position: relative; | |||
| border-radius: ${euiTheme.size.s}; | |||
jennypavlova
approved these changes
Sep 5, 2023
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
crespocarlos
deleted the
165194-fix-relative-date-range-content-reload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #165194
Summary
This PR fixes the problem with the Asset Details not reloading its content when date-picker had relative dates.
flyout
flyout.mov
full-page
full_page.mov
I've also changed all the charts to receive absolute date ranges. If they used relative dates,
nowwill be calculated when each chart starts loading, this could change significantly if there is a delay between loading each individual chart.How to test
nowand submit (do that one more time)nowand submit (do that one more time)