Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): skip currently unstable serverless Cypress tests #165424

Merged
merged 12 commits into from
Sep 4, 2023
Merged

chore(NA): skip currently unstable serverless Cypress tests #165424

merged 12 commits into from
Sep 4, 2023

Conversation

mistic
Copy link
Member

@mistic mistic commented Sep 1, 2023

This is a simple PR skipping some Cypress tests that are currently flaky.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.11.0 labels Sep 1, 2023
@mistic mistic marked this pull request as ready for review September 1, 2023 01:58
@mistic mistic requested a review from a team as a code owner September 1, 2023 01:58
@mistic mistic requested a review from banderror September 1, 2023 01:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from a team as a code owner September 1, 2023 02:01
@mistic mistic enabled auto-merge (squash) September 1, 2023 02:07
davismcphee
davismcphee approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ours isn't a Cypress test, but it's flaky so makes sense to skip until it's resolved. I think it might be related to timing out while trying to load the data for the tests in Serverless.

banderror
banderror approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule Management LGTM

Just FYI Tiago we (Rule Management and Detection Engine teams from Security Solution) have a few tickets for fixing broken and flaky Serverless Cypress tests in 8.11:

...press/cypress/e2e/detection_response/rule_management/rules_table/rules_table_filtering.cy.ts Outdated Show resolved Hide resolved
@mistic mistic requested a review from a team as a code owner September 1, 2023 13:19
@mistic mistic requested a review from a team as a code owner September 1, 2023 15:51
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 2, 2023 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / EPM Endpoints Install endpoint package install should have installed the [endpoint.metadata_current-default] transform

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Sep 4, 2023

Merging this now to improve the current CI on PRs

@mistic mistic disabled auto-merge September 4, 2023 02:20
@mistic mistic merged commit f7fc2da into elastic:main Sep 4, 2023
sphilipse pushed a commit to sphilipse/kibana that referenced this pull request Sep 4, 2023
@mistic @sphilipse
chore(NA): skip currently unstable serverless Cypress tests (elastic#…
fd6a14e 
…165424)

This is a simple PR skipping some Cypress tests that are currently
flaky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@banderror banderror banderror approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibana-ci @banderror @davismcphee