Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Automate generative AI connector screenshots #165420

Merged
merged 6 commits into from
Sep 6, 2023
Merged

[DOCS] Automate generative AI connector screenshots #165420

merged 6 commits into from
Sep 6, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 31, 2023 •
edited by kibanamachine
Loading

Summary

This PR automates two screenshots from https://www.elastic.co/guide/en/kibana/master/gen-ai-action-type.html

NOTE: These screenshots seem to be impacted by #162204, which implies there are text changes required as well.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.11.0 labels Aug 31, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review September 1, 2023 15:16
@lcawl lcawl requested a review from a team as a code owner September 1, 2023 15:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl mentioned this pull request Sep 1, 2023
Closed
@pmuellr
Copy link
Member

pmuellr commented Sep 5, 2023

These screenshots seem to be impacted by #162204, which implies there are text changes required as well.

Ya, there was a change from that issue to add some new config I believe - best to check with Dario or Steph for new copy.

pmuellr
pmuellr approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we'll want Steph or Dario to take a look. The text in the new example of "Hello World" seems out-of-place, at least compared to what was being replaced.

@kibanamachine kibanamachine requested a review from a team as a code owner September 6, 2023 16:10
@lcawl lcawl removed the request for review from a team September 6, 2023 16:50
@lcawl
Copy link
Contributor Author

lcawl commented Sep 6, 2023

LGTM, but I think we'll want Steph or Dario to take a look. The text in the new example of "Hello World" seems out-of-place, at least compared to what was being replaced.

Good point, I've updated the screenshot to replace the default text with what we had in the original example.

@lcawl lcawl enabled auto-merge (squash) September 6, 2023 16:51
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 6, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 633aebe into elastic:main Sep 6, 2023
@kibanamachine kibanamachine mentioned this pull request Sep 6, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 6, 2023
@lcawl
[DOCS] Automate generative AI connector screenshots (elastic#165420)
30e6080 
(cherry picked from commit 633aebe)
@kibanamachine kibanamachine mentioned this pull request Sep 8, 2023
Merged
lcawl added a commit that referenced this pull request Sep 8, 2023
@kibanamachine @lcawl
[8.10] [DOCS] Automate generative AI connector screenshots (#165420) (#…
585fb78 
…165891)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[DOCS] Automate generative AI connector screenshots
(#165420)](#165420)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-06T17:51:13Z","message":"[DOCS]
Automate generative AI connector screenshots
(#165420)","sha":"633aebe5fc46bc031358212a8015cfcea2cd9047","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorTypes","backport:prev-minor","v8.11.0"],"number":165420,"url":"https://github.com/elastic/kibana/pull/165420","mergeCommit":{"message":"[DOCS]
Automate generative AI connector screenshots
(#165420)","sha":"633aebe5fc46bc031358212a8015cfcea2cd9047"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165420","number":165420,"mergeCommit":{"message":"[DOCS]
Automate generative AI connector screenshots
(#165420)","sha":"633aebe5fc46bc031358212a8015cfcea2cd9047"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @apmmachine @elasticmachine @pmuellr @kibana-ci @kibanamachine