Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] experiment: make all alert doc updates partial #165275

Closed
wants to merge 3 commits into from

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Aug 30, 2023

work in progress

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 1, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / Alerts Client using aliases for alert indices persistAlerts() should not update ongoing alerts in existing index when they are not in the processed alerts
  • [job] [logs] Jest Tests #16 / Alerts Client using aliases for alert indices persistAlerts() should recover recovered alerts in existing index
  • [job] [logs] Jest Tests #16 / Alerts Client using aliases for alert indices persistAlerts() should update ongoing alerts in existing index
  • [job] [logs] Jest Tests #16 / Alerts Client using aliases for alert indices setAlertData() should successfully update context and payload for ongoing alert
  • [job] [logs] Jest Tests #16 / Alerts Client using aliases for alert indices setAlertData() should successfully update context and payload for recovered alert
  • [job] [logs] Jest Tests #16 / Alerts Client using data streams for alert indices persistAlerts() should not update ongoing alerts in existing index when they are not in the processed alerts
  • [job] [logs] Jest Tests #16 / Alerts Client using data streams for alert indices persistAlerts() should recover recovered alerts in existing index
  • [job] [logs] Jest Tests #16 / Alerts Client using data streams for alert indices persistAlerts() should update ongoing alerts in existing index
  • [job] [logs] Jest Tests #16 / Alerts Client using data streams for alert indices setAlertData() should successfully update context and payload for ongoing alert
  • [job] [logs] Jest Tests #16 / Alerts Client using data streams for alert indices setAlertData() should successfully update context and payload for recovered alert
  • [job] [logs] Jest Tests #6 / createLifecycleExecutor set flapping on the document updates documents with flapping for active alerts
  • [job] [logs] Jest Tests #6 / createLifecycleExecutor set flapping on the document updates existing documents for recovered alerts
  • [job] [logs] Jest Tests #6 / createLifecycleExecutor set maintenance window ids on the document does not update documents with maintenance window ids for recovered alerts
  • [job] [logs] Jest Tests #6 / createLifecycleExecutor set maintenance window ids on the document does not update documents with maintenance window ids for repeatedly firing alerts
  • [job] [logs] Jest Tests #6 / createLifecycleExecutor updates existing documents for recovered alerts
  • [job] [logs] Jest Tests #6 / createLifecycleExecutor updates existing documents for repeatedly firing alerts
  • [job] [logs] Jest Tests #6 / createLifecycleRuleTypeFactory with a new rule when alerts recover writes the correct alerts
  • [job] [logs] FTR Configs #32 / endpoint App level Endpoint functionality from Timeline should show Isolation action in alert details
  • [job] [logs] FTR Configs #32 / endpoint App level Endpoint functionality from Timeline should show Isolation action in alert details
  • [job] [logs] FTR Configs #3 / Synthetics API Tests SyncGlobalParams added an integration for previously added monitor
  • [job] [logs] FTR Configs #3 / Synthetics API Tests SyncGlobalParams added an integration for previously added monitor

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5580 +5580
total size - 6.0MB +6.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pmuellr pmuellr closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants