Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable flaky #165237

Merged
merged 3 commits into from
Aug 30, 2023
Merged

enable flaky #165237

merged 3 commits into from
Aug 30, 2023

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Aug 30, 2023 •
edited by kibanamachine
Loading

Re-enable flaky tests

Closes #161624
Closes #156941

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Aug 30, 2023
@juliaElastic juliaElastic self-assigned this Aug 30, 2023
@juliaElastic juliaElastic requested a review from a team as a code owner August 30, 2023 13:24
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@juliaElastic juliaElastic enabled auto-merge (squash) August 30, 2023 14:07
@juliaElastic juliaElastic merged commit 77f1a11 into elastic:main Aug 30, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / detection engine api security and spaces enabled - Group 10 import_rules importing rules with different roles "after all" hook for "should not import rules with actions when a user has no actions privileges"
  • [job] [logs] FTR Configs #29 / detection engine api security and spaces enabled - Group 10 import_rules importing rules with different roles "before all" hook for "should successfully import rules without actions when user has no actions privileges"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@kibanamachine kibanamachine mentioned this pull request Aug 30, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 30, 2023
@juliaElastic
enable flaky (elastic#165237)
bf13c9c 
Re-enable flaky tests

Closes elastic#161624
Closes elastic#156941

(cherry picked from commit 77f1a11)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 30, 2023
@kibanamachine @juliaElastic
[8.10] enable flaky (#165237) (#165253)
8ffd2ea 
# Backport

This will backport the following commits from `main` to `8.10`:
- [enable flaky
(#165237)](#165237)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Bardi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-30T15:59:19Z","message":"enable
flaky (#165237)\n\nRe-enable flaky tests\r\n\r\nCloses
https://github.com/elastic/kibana/issues/161624\r\nCloses
https://github.com/elastic/kibana/issues/156941","sha":"77f1a11f11a443667e78c1afbbebee4d901b5431","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.10.0","v8.11.0"],"number":165237,"url":"https://github.com/elastic/kibana/pull/165237","mergeCommit":{"message":"enable
flaky (#165237)\n\nRe-enable flaky tests\r\n\r\nCloses
https://github.com/elastic/kibana/issues/161624\r\nCloses
https://github.com/elastic/kibana/issues/156941","sha":"77f1a11f11a443667e78c1afbbebee4d901b5431"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165237","number":165237,"mergeCommit":{"message":"enable
flaky (#165237)\n\nRe-enable flaky tests\r\n\r\nCloses
https://github.com/elastic/kibana/issues/161624\r\nCloses
https://github.com/elastic/kibana/issues/156941","sha":"77f1a11f11a443667e78c1afbbebee4d901b5431"}}]}]
BACKPORT-->

Co-authored-by: Julia Bardi <[email protected]>
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Aug 31, 2023
@juliaElastic @eokoneyo
enable flaky (elastic#165237)
67750ee 
Re-enable flaky tests

Closes elastic#161624
Closes elastic#156941
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

Assignees

@juliaElastic juliaElastic

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
6 participants
@juliaElastic @elasticmachine @apmmachine @kibana-ci @kibanamachine @jlind23