Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slo): add partition by field in APM indicators #165106

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

kdelemme
Copy link
Contributor

Resolves https://github.com/elastic/actionable-observability/issues/121

Summary

This PR adds the partition by field selector in the APM indicator forms

Dashboard Create Form Edit Form
image image image

@kdelemme kdelemme self-assigned this Aug 29, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme added v8.11.0 release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" backport v8.10.0 labels Aug 29, 2023
@kdelemme kdelemme marked this pull request as ready for review August 29, 2023 14:24
@kdelemme kdelemme requested a review from a team as a code owner August 29, 2023 14:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme removed the v8.10.0 label Aug 29, 2023
@simianhacker
Copy link
Member

/oblt-deploy-serverless

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #14 / Profiling API tests feature_controls.spec.ts cloud Loading profiling data Profiling feature controls returns ok for users with access to profiling APIs

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB +124.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kdelemme kdelemme merged commit e56c0f6 into elastic:main Aug 30, 2023
@kdelemme kdelemme deleted the slo-apm-partition-by branch August 30, 2023 13:57
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 30, 2023
@kdelemme kdelemme added v8.10.0 and removed backport:skip This commit does not require backporting labels Aug 30, 2023
@kdelemme
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kdelemme added a commit to kdelemme/kibana that referenced this pull request Sep 29, 2023
kdelemme added a commit that referenced this pull request Sep 29, 2023
…167652)

# Backport

This will backport the following commits from `main` to `8.10`:
- [feat(slo): add partition by field in APM indicators
(#165106)](#165106)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-30T13:57:10Z","message":"feat(slo):
add partition by field in APM indicators
(#165106)","sha":"e56c0f61eddbb5dd377a7893cfb69d9044d3d86f","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:
Actionable
Observability","v8.10.0","v8.11.0"],"number":165106,"url":"https://github.com/elastic/kibana/pull/165106","mergeCommit":{"message":"feat(slo):
add partition by field in APM indicators
(#165106)","sha":"e56c0f61eddbb5dd377a7893cfb69d9044d3d86f"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165106","number":165106,"mergeCommit":{"message":"feat(slo):
add partition by field in APM indicators
(#165106)","sha":"e56c0f61eddbb5dd377a7893cfb69d9044d3d86f"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0 v8.10.3 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants