-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Defend Workflows] Add tags for mocked and real Endpoint Cypress tests for Serverless #165094
Merged
gergoabraham
merged 37 commits into
elastic:main
from
gergoabraham:test/olm-7133-reuse-tests-for-serverless
Sep 20, 2023
+682
−408
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
b6642b6
add `cypress:dw:serverless:*` scripts
gergoabraham 8cc56e7
add `Elastic-Api-Version` to all cy requests
gergoabraham 8645b2c
add `http.host` to shared setting, so ES is accessible via local IP
gergoabraham db6b729
add config and scripts for real endpoint serverless
gergoabraham b51cdbf
fix test scripts (removing `ts` and `open` from shared scripts)
gergoabraham 774c548
add `@ess` tag for every test
gergoabraham c85ec25
fix eslint errors
gergoabraham 26f13f1
add `@ess` grep to ess test configs
gergoabraham 96681c4
fine tune grep config
gergoabraham 171d093
move cypress configs into cypress folder
gergoabraham d012eaf
run tests on CI
gergoabraham 5bd9599
add `@serverless` tag to selected cypress tests
gergoabraham bdabdfa
fix eslint errors
gergoabraham df6c6f6
improve earlier eslint fix: remove unnecessary click
gergoabraham 5b3f9e5
add `@brokenInServerless` to all "real endpoint" tests, until we got …
gergoabraham f01466d
add reporter config to cypress configs
gergoabraham 0715a0c
fix lint errors
gergoabraham 783402a
remove CI job for real endpoints against serverless
gergoabraham addb780
remove `@brokenInServerless` tags from skipped real endpoint tests
gergoabraham 0019766
fix the eslint fix
gergoabraham 4da5f86
run a placeholder test case for mocked_data
gergoabraham 48ec79d
Revert "remove `@brokenInServerless` tags from skipped real endpoint …
gergoabraham 3aaf36a
Revert "remove CI job for real endpoints against serverless"
gergoabraham 88d79c2
run a placeholder test case for real endpoint serverless tests
gergoabraham bf44385
remove placeholder tests
gergoabraham 4ac5a03
prevent `junit:merge` from failing CI step
gergoabraham 08fab69
Merge branch 'main' into test/olm-7133-reuse-tests-for-serverless
gergoabraham 4a0cea8
remove `http.host` server arg from shared config
gergoabraham 11132d6
prepare `runEndpointLoaderScript()` for serverless
gergoabraham 63e5342
add `dataLoaders()` back to serverless config
gergoabraham a2dca01
enable `Policy Details` cy test for serverless
gergoabraham 6ae9f21
re-enable configurations that have problems fixed
gergoabraham b08267a
update readme
gergoabraham ad1c3fe
add reusable base config for cypress
gergoabraham 6f90e66
Merge branch 'main' into test/olm-7133-reuse-tests-for-serverless
gergoabraham 7ec96a3
add IS_SERVERLESS to cy config
gergoabraham 75cde75
convert base config to a function instead of const
gergoabraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add
@brokenInServerless
to all "real endpoint" tests, until we got …
…a workaround
commit 5b3f9e53377eb7415d035b4dac69d220e3f32fe2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could type this new property (
tags
) so that we get content assist. Can you add that to ourcypress.d.ts
file here:kibana/x-pack/plugins/security_solution/public/management/cypress/cypress.d.ts
Lines 38 to 42 in 054cdba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - looks like
tags
is already defined via@cypress
types so need to add to the ourcypress.d.ts
file. I do wonder if there is a way to make the type more specific in that it can suggest our "known" tags 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some experiments with types to be able to have suggestions, but didn't work so far, exactly because
tags
are already defined incypress.d.ts
, and therefore it cannot be overriden by a more exact type.one solution would be to use our own
security_tags
or something, but I'm not sure if grep can pick it up - I'll look into this, but this is definitely an open question.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no big deal. it would just help with DX. Don't hold this PR because of this.