Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted fixes #165039

Merged
merged 17 commits into from
Aug 30, 2023
Merged

Assorted fixes #165039

merged 17 commits into from
Aug 30, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Aug 28, 2023 •
edited by kibanamachine
Loading

Resolves https://github.com/elastic/obs-ai-assistant-team/issues/51

Summary

This adds:

  • Incorrect License blocking
  • Chat Header styling tweaks passed down by the Boris
  • Chat Welcome message
  • Experimental Feature banner with feedback button which links to GForm

This fixes:

  • When a conversation fails and the user clicks "New chat" the errored message is no longer added to the newly created chat
  • Better checking for falsey values when evaluating errors

@CoenWarmer CoenWarmer requested a review from a team as a code owner August 28, 2023 20:16
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

dgieselaar
dgieselaar reviewed Aug 29, 2023
View reviewed changes
x-pack/plugins/observability_ai_assistant/public/components/chat/chat_body.tsx Outdated Show resolved Hide resolved
x-pack/plugins/observability_ai_assistant/public/components/chat/chat_header.tsx Outdated Show resolved Hide resolved
x-pack/plugins/observability_ai_assistant/public/hooks/use_timeline.ts
Comment on lines +95 to +100
const prevConversationId = usePrevious(conversationId);
useEffect(() => {
if (prevConversationId !== conversationId && pendingMessage?.error) {
setPendingMessage(undefined);
}
}, [conversationId, pendingMessage?.error, prevConversationId]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it only needs to be cleared when there is an error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate? What other scenarios do you think this should happen? Not seeing any obvious errors atm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you start a new conversation, and wait until it's stored, add a new message, and immediately click on "new chat" (while the assistant response is being loaded), the pending message is added there (in the new conversation). You can also use an existing conversation, do the same and then click on another conversation.

@CoenWarmer CoenWarmer requested a review from dgieselaar August 29, 2023 22:30
@CoenWarmer CoenWarmer added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Aug 29, 2023
@CoenWarmer CoenWarmer enabled auto-merge (squash) August 30, 2023 00:20
@CoenWarmer CoenWarmer force-pushed the feat/obs-assistant-qa-3 branch from 446a081 to beb7fb9 Compare August 30, 2023 00:20
@CoenWarmer CoenWarmer force-pushed the feat/obs-assistant-qa-3 branch from beb7fb9 to 2f0b4f6 Compare August 30, 2023 00:42
@CoenWarmer CoenWarmer force-pushed the feat/obs-assistant-qa-3 branch from c02b5d7 to 909ce56 Compare August 30, 2023 09:45
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAIAssistant 205 212 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 164.8KB 168.7KB +3.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 9.0KB 9.1KB +132.0B
Unknown metric groups

miscellaneous assets size

id before after diff
observabilityAIAssistant 0.0B 763.8KB ⚠️ +763.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 58cf152 into elastic:main Aug 30, 2023
@kibanamachine kibanamachine mentioned this pull request Aug 30, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 30, 2023
@CoenWarmer
Assorted fixes (elastic#165039)
cc982ae 
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 58cf152)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 30, 2023
@kibanamachine @CoenWarmer
[8.10] Assorted fixes (#165039) (#165212)
8d70f81 
# Backport

This will backport the following commits from `main` to `8.10`:
- [Assorted fixes
(#165039)](#165039)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Coen
Warmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-30T10:46:32Z","message":"Assorted
fixes (#165039)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"58cf152dccf661a912156fc51d1c9e46029c97a6","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.11.0"],"number":165039,"url":"https://github.com/elastic/kibana/pull/165039","mergeCommit":{"message":"Assorted
fixes (#165039)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"58cf152dccf661a912156fc51d1c9e46029c97a6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165039","number":165039,"mergeCommit":{"message":"Assorted
fixes (#165039)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"58cf152dccf661a912156fc51d1c9e46029c97a6"}}]}]
BACKPORT-->

Co-authored-by: Coen Warmer <[email protected]>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CoenWarmer @apmmachine @kibana-ci @kibanamachine @dgieselaar