Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard Navigation] Store unwrapped attributes in componentState #164887

Merged
merged 1 commit into from
Aug 28, 2023
Merged

[Dashboard Navigation] Store unwrapped attributes in componentState #164887

merged 1 commit into from
Aug 28, 2023

Conversation

nickpeihl
Copy link
Member

Fixes #164322

Store the unwrapped attributes from by-reference links panels in componentState.

Since the explictInput for a Links panel can be either by-reference or by-value, we need to be sure to share the unwrapped attributes (as in from a by-reference panel) to our component.

@nickpeihl nickpeihl added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Aug 25, 2023
@nickpeihl nickpeihl requested a review from Heenawter August 25, 2023 18:24
@nickpeihl nickpeihl requested a review from a team as a code owner August 25, 2023 18:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 25, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #5 / checking migration metadata changes on all registered SO types detecting migration related changes in registered types
  • [job] [logs] FTR Configs #32 / Controls Range Slider Control create and edit edits title and size of an existing control and retains existing range selection
  • [job] [logs] FTR Configs #32 / Controls Range Slider Control create and edit edits title and size of an existing control and retains existing range selection
  • [job] [logs] FTR Configs #44 / Options list control Dashboard options list creation and editing Options List Control creation and editing experience renames an existing control and retains selection
  • [job] [logs] FTR Configs #44 / Options list control Dashboard options list creation and editing Options List Control creation and editing experience renames an existing control and retains selection
  • [job] [logs] Jest Integration Tests #6 / SO type registrations does not remove types from registrations without updating excludeOnUpgradeQuery

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [6fa536c]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Heenawter
Heenawter approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only - very straightforward 👍

src/plugins/navigation_embeddable/public/components/navigation_embeddable_component.tsx
Comment on lines +25 to +26
const links = navEmbeddable.select((state) => state.componentState.links);
const layout = navEmbeddable.select((state) => state.componentState.layout);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner 🎉

@nickpeihl nickpeihl merged commit d51bcd8 into elastic:navigation-embeddable Aug 28, 2023
@nickpeihl nickpeihl mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees
No one assigned
Labels
Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickpeihl @elasticmachine @kibana-ci @Heenawter