Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Update config template for self managed connectors. #164854

Merged
merged 2 commits into from
Aug 25, 2023
Merged

[Enterprise Search] Update config template for self managed connectors. #164854

merged 2 commits into from
Aug 25, 2023

Conversation

efegurkan
Copy link
Member

@efegurkan efegurkan commented Aug 25, 2023 •
edited by kibanamachine
Loading

Summary

Screen.Recording.2023-08-25.at.16.55.42.mov

@efegurkan efegurkan added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Aug 25, 2023
@efegurkan efegurkan requested a review from a team August 25, 2023 14:59
@efegurkan efegurkan added the ci:cloud-deploy Create or update a Cloud deployment label Aug 25, 2023
@leemthompo
Copy link
Contributor

leemthompo commented Aug 25, 2023 •
edited
Loading

Would be cool if host actually used the cloud ES endpoint for cloud deployments 🤔

[edit: it does]

efegurkan
efegurkan commented Aug 25, 2023
View reviewed changes
...public/applications/enterprise_search_content/components/search_index/connector/constants.ts
}

elasticsearch:
host: "${host || 'https://locahost:9200'}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leemthompo it will use cloud when available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, thanks for confirming @efegurkan ❤️

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +811.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efegurkan efegurkan added ci:cloud-deploy Create or update a Cloud deployment and removed ci:cloud-deploy Create or update a Cloud deployment labels Aug 25, 2023
@efegurkan efegurkan merged commit 7e4b67e into elastic:main Aug 25, 2023
@efegurkan efegurkan deleted the update-connector-config branch August 25, 2023 17:06
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2023
@efegurkan
[Enterprise Search] Update config template for self managed connector…
0b2b482 
…s. (elastic#164854)

## Summary

https://github.com/elastic/kibana/assets/1410658/e9e1dfb3-1acd-4255-9abf-b9b58f1a060a
(cherry picked from commit 7e4b67e)
kibanamachine added a commit that referenced this pull request Aug 25, 2023
@kibanamachine @efegurkan
[8.10] [Enterprise Search] Update config template for self managed co…
4f85aa3 
…nnectors. (#164854) (#164874)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Enterprise Search] Update config template for self managed
connectors. (#164854)](#164854)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Efe Gürkan
YALAMAN","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-25T17:06:01Z","message":"[Enterprise
Search] Update config template for self managed connectors.
(#164854)\n\n##
Summary\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/e9e1dfb3-1acd-4255-9abf-b9b58f1a060a","sha":"7e4b67e2390ff0d2637b10153c049da73ee6ab34","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","ci:cloud-deploy","v8.10.0","v8.11.0"],"number":164854,"url":"https://github.com/elastic/kibana/pull/164854","mergeCommit":{"message":"[Enterprise
Search] Update config template for self managed connectors.
(#164854)\n\n##
Summary\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/e9e1dfb3-1acd-4255-9abf-b9b58f1a060a","sha":"7e4b67e2390ff0d2637b10153c049da73ee6ab34"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164854","number":164854,"mergeCommit":{"message":"[Enterprise
Search] Update config template for self managed connectors.
(#164854)\n\n##
Summary\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/e9e1dfb3-1acd-4255-9abf-b9b58f1a060a","sha":"7e4b67e2390ff0d2637b10153c049da73ee6ab34"}}]}]
BACKPORT-->

Co-authored-by: Efe Gürkan YALAMAN <[email protected]>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo left review comments

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@efegurkan @leemthompo @kibana-ci @kibanamachine @TattdCodeMonkey