[pluginSystem] optimize plugins stop execution #164831
Conversation
pgayvallet
added
Feature:Plugins
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
added
the
release_note:skip
|
|
||
| this.log.debug(`Stopping plugin "${pluginName}"...`); | ||
| // Stop plugin as soon as all the dependant plugins are stopped. | ||
| const pluginStopPromise = Promise.all(dependantPromises).then(async () => { |
There was a problem hiding this comment.
nit: should we use Promise.allSettled instead?
There was a problem hiding this comment.
Old behavior was to throw on first error, so I just kept it tbh. It may be better to wait for everything, but I was kinda scared to change.
There was a problem hiding this comment.
The only difference is that now we are running multiple stops at the same time. So we may cancel ongoing promises.
IMO, it's OK not to continue calling other stops, but I feel uneasy cancelling running calls (despite our stop is not guaranteed to be called policy).
Happy to merge as is, though.
There was a problem hiding this comment.
Fair point. it would be a bit challenging to only cancel the running promises and would over complexify the flow. I will adapt to wait for everything instead and use allSettled 👍
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Related to #163519
Optimize the way we're shutting down plugins, by calling
stopfor each plugin as soon as all dependant plugins are stopped, instead of just doing it one-by-one.