Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9] [Security Solution] Fix flakiness in: prebuilt_rules_management.cy.ts - Deletes and recovers more than one rule #164824

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Aug 25, 2023

NOTE: This is a manual backport of #164694

Relates to: #161507

Summary

  • Solves flakiness in following test:

    • Filename: x-pack/plugins/security_solution/cypress/e2e/detection_rules/prebuilt_rules_management.cy.ts
    • Test name: Prebuilt rules Actions with prebuilt rules Rules table Deletes and recovers more than one rule
  • Test was failing because of already observed issue of autoRefresh taking place while the rule selection is happening, causing Cypress to lose focus and preventing the checkbox from being checked. This PR disables autorefresh from the table to prevent that from happening.

Flaky test runner

350 iters: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2976 🟢

@jpdjere jpdjere added test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Aug 25, 2023
@jpdjere jpdjere requested a review from maximpn August 25, 2023 10:35
@jpdjere jpdjere self-assigned this Aug 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpdjere jpdjere merged commit 41f6c48 into elastic:8.9 Aug 28, 2023
@jpdjere jpdjere added the flake-docs Temp label to gather PRs used to create dev docs label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area flake-docs Temp label to gather PRs used to create dev docs release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants