Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Improve loading time for populated fields in Transform creation wizard #164790

Merged
merged 6 commits into from
Aug 30, 2023
Merged

[ML] Improve loading time for populated fields in Transform creation wizard #164790

merged 6 commits into from
Aug 30, 2023

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Aug 24, 2023 •
edited
Loading

Summary

Follow up of #163371. This PR reduces the extra call in Transform as the same request to fetch 500 sample docs have already been made via the Field Stats provider. It also reduces the number of docs fetched from 1000 to 500 for consistency.

If the performance journey improves, we can make the same change to Data Frame Analytics.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 changed the title [ML] Improve loading time in Transform creation wizard [ML] Improve loading time for populated fields in Transform creation wizard Aug 25, 2023
@qn895 qn895 marked this pull request as ready for review August 28, 2023 16:06
@qn895 qn895 requested a review from a team as a code owner August 28, 2023 16:06
@qn895 qn895 self-assigned this Aug 28, 2023
@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v8.11.0 labels Aug 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member Author

qn895 commented Aug 28, 2023

@elasticmachine merge upstream

walterra
walterra approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + test LGTM.

peteharverson
peteharverson approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

Will be interesting to see how the results from the performance journey test look after this change. Largest number of fields I tested with was metrics-ui-downsample which has 3600 fields, but was visually hard to tell the scale of the performance improvement.

@qn895
Copy link
Member Author

qn895 commented Aug 30, 2023

@elasticmachine merge upstream

@qn895 qn895 enabled auto-merge (squash) August 30, 2023 15:46
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts / alerting api integration security and spaces enabled - Group 2 Connectors CasesWebhook CasesWebhook - Executor Validation should handle failing with a simulated success without comment message

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +159.0B
transform 405.6KB 405.8KB +212.0B
total +371.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 merged commit bab03d4 into elastic:main Aug 30, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 30, 2023
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Aug 31, 2023
@qn895 @kibanamachine @eokoneyo
[ML] Improve loading time for populated fields in Transform creation …
966c91c 
…wizard (elastic#164790)

## Summary

Follow up of elastic#163371. This PR
reduces the extra call in Transform as the same request to fetch 500
sample docs have already been made via the Field Stats provider. It also
reduces the number of docs fetched from 1000 to 500 for consistency.

If the performance journey improves, we can make the same change to Data
Frame Analytics.
### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
@dmlemeshko
Copy link
Member

Will be interesting to see how the results from the performance journey test look after this change. Largest number of fields I tested with was metrics-ui-downsample which has 3600 fields, but was visually hard to tell the scale of the performance improvement.

It is quite impressive drop!

image

I'm in progress to verify locally as it looks quite amazing 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@qn895 qn895

Labels
backport:skip This commit does not require backporting Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qn895 @elasticmachine @kibana-ci @dmlemeshko @walterra @peteharverson @kibanamachine