[Security Solution] ensure fleetfilenotfound is reported as a 404 #164738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzl
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
ashokaditya
approved these changes
Aug 24, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kevinlog
approved these changes
Aug 24, 2023
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ashokaditya
pushed a commit
to ashokaditya/kibana
that referenced
this pull request
Aug 25, 2023
…astic#164738) (cherry picked from commit 9e89a96)
ashokaditya
added a commit
that referenced
this pull request
Aug 25, 2023
…404 (#164738) (#164836) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] ensure fleetfilenotfound is reported as a 404 (#164738)](#164738) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dan Panzarella","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-24T19:48:10Z","message":"[Security Solution] ensure fleetfilenotfound is reported as a 404 (#164738)","sha":"9e89a9694b9bacc275f8d2125200b53447a13f1f","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.10.0","v8.11.0"],"number":164738,"url":"https://github.com/elastic/kibana/pull/164738","mergeCommit":{"message":"[Security Solution] ensure fleetfilenotfound is reported as a 404 (#164738)","sha":"9e89a9694b9bacc275f8d2125200b53447a13f1f"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164738","number":164738,"mergeCommit":{"message":"[Security Solution] ensure fleetfilenotfound is reported as a 404 (#164738)","sha":"9e89a9694b9bacc275f8d2125200b53447a13f1f"}}]}] BACKPORT--> Co-authored-by: Dan Panzarella <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug during upgrade, wherein files uploaded prior to version 8.10 are deleted, but the error messaging displayed a 500 error. This has been fixed to show a proper message
For maintainers