[Serverless Elasticsearch] Fix user is blocked from moving forward when opening Discover, Dashboard, or Visualize Library #164709

Dosant · 2023-08-24T13:04:59Z

Summary

AnalyticsNoDataPage could only point to "Integrations" (fleet), but serverless search disabled fleet plugin. The AnalyticsNoDataPage started showing "no access to fleet" state. This PR fixes it and shows empty state that makes sense for serverless search project:

In this PR I am hacking together a way to override the content of the AnalyticsNoDataPage:

AnalyticsNoDataPage could only point to "Integrations". Some integrations-specific URLs and access checks are hardcoded deep inside the component. If the fleet plugin was not available, it just showed that the user didn't have access.
AnalyticsNoDataPage introduces "flavor" ('kibana' | 'serverless_search'). Depending on flavor it passes down different texts for the page and the card. There is also a canAccessFleet hack that forces it to "true" for the serverless_search flavor. This is needed to skip the fleet plugin access from inside the component and to avoid showing a "no permissions state". This needs to be refactored: probably, the inner card shouldn't be so tightly coupled to fleet
The no_data_page plugin is added to register the new config no_data_page.analyticsNoDataPageFlavor: 'serverless_search'. Analytics apps will pass the plugin down to the AnalyticsNoDataPage so it can pick the flavor. The introduced plugin is the downside of having such a complex page as a stateless component. An Alternative could be if discover, visualize, dashboard would register their configs to pass down to AnalyticsNoDataPage.

Dosant · 2023-08-24T13:06:38Z

src/plugins/no_data_page/README.md

@@ -0,0 +1,3 @@
+# No Data Page
+
+Helps to globally configure the no data page components


Need this dummy plugin to create a config for configuring the analytics empty pages "flavor"

An alternative could be that all discover, visualize, dashboards expose this config on their own and pass it to the component.

Dosant · 2023-08-24T13:07:21Z

packages/shared-ux/page/no_data/impl/src/no_data_page.tsx

@@ -33,13 +33,13 @@ export const NoDataPage = ({
      values: { solution },
    });

-  const link = (
+  const link = docsLink ? (


Making docsLink here optional to skip the docs link for serverless search empty page for now

Dosant · 2023-08-24T13:10:35Z

packages/shared-ux/page/analytics_no_data/impl/src/analytics_no_data_page.component.tsx

+        'data-test-subj': 'kbnOverviewElasticsearchGettingStarted',
+        href: prependBasePath('/app/elasticsearch/'),
+        /** force the no data card to be shown **/
+        canAccessFleet: true,


Passing/faking this explicitly so that NoDataCard doesn't fallback to the "no access to fleet" page. This needs to be refactored.

Currently, it is ugly: even though the NoDataCard seems to be generic and text and links can be configured through props, some "fleet" logic parts are still hardcoded inside the component. For example, the component checks the access to fleet through context.

Dosant · 2023-08-24T13:13:11Z

packages/shared-ux/page/analytics_no_data/impl/src/analytics_no_data_page.component.tsx

+            'Set up your programming language client, ingest some data, and start searching.',
+        }),
+        'data-test-subj': 'kbnOverviewElasticsearchGettingStarted',
+        href: prependBasePath('/app/elasticsearch/'),


href on this level is added only for "serverless_search" flavor, but not for "kibana" flavor because the integrations page is already hardcoded inside the component. The NoDataCard must be refactored to be fully configurable and don't hardcode fleet stuff.

…ocs'

…into d/2023-08-23-search-empty

…fix'

…into d/2023-08-23-search-empty

Dosant · 2023-08-25T11:39:11Z

src/plugins/discover/public/application/main/discover_main_route.tsx

@@ -109,7 +105,7 @@ export function DiscoverMainRoute({
      const hasUserDataViewValue = await data.dataViews.hasData
        .hasUserDataView()
        .catch(() => false);
-      const hasESDataValue = isDev || (await data.dataViews.hasData.hasESData().catch(() => false));
+      const hasESDataValue = await data.dataViews.hasData.hasESData().catch(() => false);


@elastic/kibana-data-discovery, hope you don't mind. Because of isDev check I couldn't add a functional test for this state that would pass locally. This also made it harder to discover the bug

I think this is fine, its was introduced to resolve #133273
Implemented in #133461

But I now tested what was mentioned not to work in #133273, so I think it has been resolved differently in the meantime?

It seems that isDev is now deprecated, which means we should cleanup in a follow up

…fix'

Dosant · 2023-08-25T13:35:04Z

@elasticmachine merge upstream

elasticmachine · 2023-08-25T14:51:52Z

Pinging @elastic/appex-sharedux (Team:SharedUX)

ThomThomson

New Dashboard service LGTM! Code only review. Great to see this addressed.

afharo

Changes to config/serverless.es.yml LGTM

kc13greiner

LGTM!

stratoula

Visualize listing page LGTM!

…-empty

sebelga

LGTM! Tested locally and works as expected.

kibana-ci · 2023-08-28T13:36:48Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dashboard`	388	389	+1
`noDataPage`	-	4	+4
total			+5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`noDataPage`	-	3	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.0MB	1.0MB	+188.0B
`dashboard`	368.6KB	370.0KB	+1.4KB
`discover`	562.7KB	564.0KB	+1.2KB
`enterpriseSearch`	2.6MB	2.6MB	+188.0B
`eventAnnotation`	176.7KB	176.9KB	+188.0B
`filesManagement`	89.7KB	89.9KB	+188.0B
`graph`	407.8KB	408.0KB	+188.0B
`home`	163.9KB	164.1KB	+188.0B
`infra`	2.0MB	2.0MB	+188.0B
`kibanaOverview`	43.9KB	45.1KB	+1.2KB
`lens`	1.4MB	1.4MB	+1.2KB
`management`	42.5KB	42.6KB	+188.0B
`maps`	2.8MB	2.8MB	+188.0B
`ml`	3.5MB	3.5MB	+188.0B
`observabilityShared`	35.9KB	36.1KB	+188.0B
`security`	567.8KB	568.0KB	+188.0B
`securitySolution`	16.0MB	16.0MB	+376.0B
`securitySolutionEss`	42.4KB	42.6KB	+188.0B
`securitySolutionServerless`	266.2KB	266.4KB	+188.0B
`spaces`	173.8KB	174.0KB	+188.0B
`visualizations`	263.5KB	264.8KB	+1.3KB
total			+9.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	31.5KB	31.5KB	+24.0B
`esUiShared`	156.3KB	156.5KB	+188.0B
`noDataPage`	-	1.4KB	+1.4KB
`visualizations`	56.8KB	56.9KB	+24.0B
total			+1.7KB

Unknown metric groups

API count

id	before	after	diff
`noDataPage`	-	3	+3

History

💛 Build #153534 was flaky 9df4624
💔 Build #153486 failed e1b7cd3
💛 Build #153278 was flaky 40e320b
💔 Build #153236 failed 6335295
💔 Build #153228 failed a558c40
💔 Build #153212 failed f6e4023

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Dosant

kertal

Thx for fixing this 👍 Tested and works as expected now 👍

sebelga · 2023-08-28T14:24:11Z

Thanks for the review @afharo @kc13greiner @stratoula @kertal @ThomThomson @jbudz !

@sphilipse if you have any feedback we can address it in a separate PR 👍

Dosant and others added 2 commits August 24, 2023 15:03

wip

9c61c00

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

743e754

Dosant commented Aug 24, 2023

View reviewed changes

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

33f17e2

…ocs'

Dosant mentioned this pull request Aug 24, 2023

[Serverless Elasticsearch] User is blocked from moving forward when opening Discover, Dashboard, or Visualize Library #164432

Closed

Dosant and others added 10 commits August 24, 2023 16:58

wip

64c26af

Merge branch 'd/2023-08-23-search-empty' of github.com:Dosant/kibana …

f6e4023

…into d/2023-08-23-search-empty

wip

a558c40

fix i18n

6335295

add test

e4afe7c

fix test

40e320b

visualize & dashboards

ba23feb

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

d634767

…fix'

add tests

2e211b5

Merge branch 'd/2023-08-23-search-empty' of github.com:Dosant/kibana …

9086b61

…into d/2023-08-23-search-empty

Dosant changed the title ~~wip [Serverless Elasticsearch] Fix user is blocked from moving forward when opening Discover, Dashboard, or Visualize Library~~ [Serverless Elasticsearch] Fix user is blocked from moving forward when opening Discover, Dashboard, or Visualize Library Aug 25, 2023

Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release labels Aug 25, 2023

Dosant self-assigned this Aug 25, 2023

Dosant commented Aug 25, 2023

View reviewed changes

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

e1b7cd3

…fix'

Merge branch 'main' into d/2023-08-23-search-empty

9df4624

Dosant marked this pull request as ready for review August 25, 2023 14:51

Dosant requested review from a team as code owners August 25, 2023 14:51

Dosant requested a review from sphilipse August 25, 2023 14:52

jbudz approved these changes Aug 25, 2023

View reviewed changes

ThomThomson approved these changes Aug 25, 2023

View reviewed changes

kc13greiner self-requested a review August 25, 2023 15:26

afharo approved these changes Aug 25, 2023

View reviewed changes

kc13greiner approved these changes Aug 25, 2023

View reviewed changes

stratoula approved these changes Aug 28, 2023

View reviewed changes

sebelga added 2 commits August 28, 2023 14:34

Update comment

0f26a4d

Merge remote-tracking branch 'upstream/main' into d/2023-08-23-search…

a276b6f

…-empty

sebelga approved these changes Aug 28, 2023

View reviewed changes

kertal self-requested a review August 28, 2023 14:10

kertal approved these changes Aug 28, 2023

View reviewed changes

sebelga merged commit 243142d into elastic:main Aug 28, 2023

kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 28, 2023

Dosant mentioned this pull request Sep 14, 2023

[Bug] Copy in empty state pages in Serverless #166233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Serverless Elasticsearch] Fix user is blocked from moving forward when opening Discover, Dashboard, or Visualize Library #164709

[Serverless Elasticsearch] Fix user is blocked from moving forward when opening Discover, Dashboard, or Visualize Library #164709

Dosant commented Aug 24, 2023 •

edited

Loading

Dosant Aug 24, 2023

Dosant Aug 24, 2023

Dosant Aug 24, 2023

Dosant Aug 24, 2023 •

edited

Loading

Dosant Aug 24, 2023 •

edited

Loading

Dosant Aug 25, 2023

kertal Aug 28, 2023

Dosant commented Aug 25, 2023

elasticmachine commented Aug 25, 2023

ThomThomson left a comment

afharo left a comment

kc13greiner left a comment

stratoula left a comment

sebelga left a comment

kibana-ci commented Aug 28, 2023

API count

kertal left a comment

sebelga commented Aug 28, 2023

		@@ -0,0 +1,3 @@
		# No Data Page

		Helps to globally configure the no data page components

[Serverless Elasticsearch] Fix user is blocked from moving forward when opening Discover, Dashboard, or Visualize Library #164709

[Serverless Elasticsearch] Fix user is blocked from moving forward when opening Discover, Dashboard, or Visualize Library #164709

Conversation

Dosant commented Aug 24, 2023 • edited Loading

Summary

Dosant Aug 24, 2023

Choose a reason for hiding this comment

Dosant Aug 24, 2023

Choose a reason for hiding this comment

Dosant Aug 24, 2023

Choose a reason for hiding this comment

Dosant Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Dosant Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Dosant Aug 25, 2023

Choose a reason for hiding this comment

kertal Aug 28, 2023

Choose a reason for hiding this comment

Dosant commented Aug 25, 2023

elasticmachine commented Aug 25, 2023

ThomThomson left a comment

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

kc13greiner left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

sebelga left a comment

Choose a reason for hiding this comment

kibana-ci commented Aug 28, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kertal left a comment

Choose a reason for hiding this comment

sebelga commented Aug 28, 2023

Dosant commented Aug 24, 2023 •

edited

Loading

Dosant Aug 24, 2023 •

edited

Loading

Dosant Aug 24, 2023 •

edited

Loading