[8.10] [Fleet] Fix security solution tag id (#164582) #164664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to elastic#152814 ## Summary Fix for a bug found in elastic#162643 : The security solution tag is actually created with "Security Solution" name and "security-solution-default" id (instead of `SecuritySolution`): ``` { "id": "security-solution-default", "name": "Security Solution", "description": "", "color": "#D36086" } ``` I found that in same cases the tag is duplicated, since[ is not created with an unique id](https://github.com/elastic/kibana/blob/dd0938bea3ebd745a49ac164a7a5f053ba6a138b/x-pack/plugins/security_solution/public/dashboards/containers/use_fetch_security_tags.ts#L44-L51): <img width="3079" alt="Screenshot 2023-08-23 at 15 07 09" src="https://github.com/elastic/kibana/assets/16084106/ef885d8f-2e68-4695-aa14-1adc2e326ab0"> I think it's acceptable to use the "security-solution-default", at least it will create the correct tag name. ### Test For testing I used a package built locally that uses the `Security Solution` tag The steps are the same as described in elastic#162643 - Additionally, check that the `tags` endpoint in the Tags page has name and id as described above: <img width="2521" alt="Screenshot 2023-08-23 at 14 55 05" src="https://github.com/elastic/kibana/assets/16084106/48b3ddd0-3d04-4ff6-8a24-946902687b13"> (cherry picked from commit da8d3b2)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: cc @criamico |
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.10:Questions ?
Please refer to the Backport tool documentation