Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Defend Workflows]Changes to policy settings are not persistent until a refresh #164403

Merged
merged 3 commits into from
Aug 23, 2023
Merged

[Defend Workflows]Changes to policy settings are not persistent until a refresh #164403

merged 3 commits into from
Aug 23, 2023

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented Aug 22, 2023 •
edited by kibanamachine
Loading

Closes https://github.com/elastic/security-team/issues/7386

Dispatch an action that will update the stored policy upon successful saving of Policy Settings. This should occur only when no 'routeState' is being set, as in such a scenario, a page change triggers a refetch on its own.

Even though redux was removed from Policy Settings in #161511 , the policy object that feeds the view is being fetched as a result of onUrlChange action and stored in the redux store. This should be addressed in the future.

Screen.Recording.2023-08-22.at.11.10.28.mov

@szwarckonrad szwarckonrad added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution backport v8.11.0 labels Aug 22, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB +102.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@szwarckonrad szwarckonrad marked this pull request as ready for review August 22, 2023 12:59
@szwarckonrad szwarckonrad requested a review from a team as a code owner August 22, 2023 12:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

dasansol92
dasansol92 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@dasansol92 dasansol92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!
Could you add a screenshot with the issue fixed?

@szwarckonrad
Copy link
Contributor Author

Recording of the issue fixed is attached to this PR and "before" recording is to be found in the ticket that this PR closes ;)

@szwarckonrad szwarckonrad merged commit 5eca861 into elastic:main Aug 23, 2023
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2023
@szwarckonrad
[Defend Workflows]Changes to policy settings are not persistent until…
46dd2d0 
… a refresh (elastic#164403)

Closes elastic/security-team#7386

Dispatch an action that will update the stored policy upon successful
saving of Policy Settings. This should occur only when no 'routeState'
is being set, as in such a scenario, a page change triggers a refetch on
its own.

Even though redux was removed from Policy Settings in
elastic#161511 , the policy object that
feeds the view is being fetched as a result of onUrlChange action and
stored in the redux store. This should be addressed in the future.

https://github.com/elastic/kibana/assets/29123534/cf008d0e-804a-49f9-a2f7-9bb7d1162b28
(cherry picked from commit 5eca861)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 23, 2023
@jloleysens
Merge branch 'main' into zdt-test-harness
fab26f8 
* main: (150 commits)
  Fixes unnecessary autocompletes on HTTP methods (elastic#163233)
  [Defend Workflows] Convert filterQuery to kql  (elastic#161806)
  [Fleet] copy `inactivity_timeout` when duplicating agent policy (elastic#164544)
  Fix 7.17 forward compatibility with 8.2+ (elastic#164274)
  [ML] Fixes dark mode in flyouts and modals (elastic#164399)
  [Defend Workflows]Changes to policy settings are not persistent until a refresh (elastic#164403)
  [Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (elastic#164329)
  Prepare the Security domain HTTP APIs for Serverless (elastic#162087)
  skip failing test suite (elastic#160986)
  [Security Solution] Fix flaky Event Filters test (elastic#164473)
  [EDR workflows] Osquery serverless tests (elastic#163795)
  [Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (elastic#164469)
  [Chrome UI] Fix background color in serverless (elastic#164419)
  [DOCS] Saved objects - resolve import errors API (elastic#162825)
  Remove 'Create Rule' button from Rule Group page (elastic#164167)
  [Security Solution] expandable flyout - fix infinite loop in correlations (elastic#163450)
  [Remote Clusters] Update copy about port help text (elastic#164442)
  [api-docs] 2023-08-23 Daily api_docs build (elastic#164524)
  [data views] Disable scripted fields in serverless environment (elastic#163228)
  [Reporting] Fix - show diagnostic only when image reporting is enabled (elastic#164336)
  ...
kibanamachine added a commit that referenced this pull request Aug 23, 2023
@kibanamachine @szwarckonrad
[8.10] [Defend Workflows]Changes to policy settings are not persisten…
4960389 
…t until a refresh (#164403) (#164557)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Defend Workflows]Changes to policy settings are not persistent until
a refresh (#164403)](#164403)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Konrad
Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-23T10:46:04Z","message":"[Defend
Workflows]Changes to policy settings are not persistent until a refresh
(#164403)\n\nCloses
https://github.com/elastic/security-team/issues/7386\r\n\r\nDispatch an
action that will update the stored policy upon successful\r\nsaving of
Policy Settings. This should occur only when no 'routeState'\r\nis being
set, as in such a scenario, a page change triggers a refetch on\r\nits
own.\r\n\r\nEven though redux was removed from Policy Settings
in\r\nhttps://github.com//pull/161511 , the policy object
that\r\nfeeds the view is being fetched as a result of onUrlChange
action and\r\nstored in the redux store. This should be addressed in the
future.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/cf008d0e-804a-49f9-a2f7-9bb7d1162b28","sha":"5eca8618eab9e6f35b1d13d9c6ae8b1df598ad5c","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Defend
Workflows","v8.10.0","v8.11.0"],"number":164403,"url":"https://github.com/elastic/kibana/pull/164403","mergeCommit":{"message":"[Defend
Workflows]Changes to policy settings are not persistent until a refresh
(#164403)\n\nCloses
https://github.com/elastic/security-team/issues/7386\r\n\r\nDispatch an
action that will update the stored policy upon successful\r\nsaving of
Policy Settings. This should occur only when no 'routeState'\r\nis being
set, as in such a scenario, a page change triggers a refetch on\r\nits
own.\r\n\r\nEven though redux was removed from Policy Settings
in\r\nhttps://github.com//pull/161511 , the policy object
that\r\nfeeds the view is being fetched as a result of onUrlChange
action and\r\nstored in the redux store. This should be addressed in the
future.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/cf008d0e-804a-49f9-a2f7-9bb7d1162b28","sha":"5eca8618eab9e6f35b1d13d9c6ae8b1df598ad5c"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164403","number":164403,"mergeCommit":{"message":"[Defend
Workflows]Changes to policy settings are not persistent until a refresh
(#164403)\n\nCloses
https://github.com/elastic/security-team/issues/7386\r\n\r\nDispatch an
action that will update the stored policy upon successful\r\nsaving of
Policy Settings. This should occur only when no 'routeState'\r\nis being
set, as in such a scenario, a page change triggers a refetch on\r\nits
own.\r\n\r\nEven though redux was removed from Policy Settings
in\r\nhttps://github.com//pull/161511 , the policy object
that\r\nfeeds the view is being fetched as a result of onUrlChange
action and\r\nstored in the redux store. This should be addressed in the
future.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/cf008d0e-804a-49f9-a2f7-9bb7d1162b28","sha":"5eca8618eab9e6f35b1d13d9c6ae8b1df598ad5c"}}]}]
BACKPORT-->

Co-authored-by: Konrad Szwarc <[email protected]>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasansol92 dasansol92 dasansol92 approved these changes

@joeypoon joeypoon joeypoon approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski patrykkopycinski was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@szwarckonrad @kibana-ci @elasticmachine @kibanamachine @joeypoon @dasansol92