[Security Solution] add cloud + endpoint metering #164331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeypoon
added
release_note:skip
joeypoon
commented
Aug 21, 2023
| @@ -42,14 +50,6 @@ export class EndpointMeteringService { | |||
| return []; | |||
| } | |||
|
|
|||
| if (!this.tier) { | |||
There was a problem hiding this comment.
we no longer need this since we're now checking add-on explicitly.
joeypoon
force-pushed
the
feature/cloud-endpoint-metering
branch
from
2d026fa to
8efa005
Compare
joeypoon
force-pushed
the
feature/cloud-endpoint-metering
branch
from
8efa005 to
ee5d3d2
Compare
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
ashokaditya
approved these changes
Aug 25, 2023
| @@ -20,6 +20,7 @@ const SAMPLE_PERIOD_SECONDS = 3600; | |||
| const THRESHOLD_MINUTES = 30; | |||
|
|
|||
| export class EndpointMeteringService { | |||
| private type: ProductLine.endpoint | `${ProductLine.cloud}_${ProductLine.endpoint}` | undefined; | |||
There was a problem hiding this comment.
nit: Perhaps better to call it pliType instead of type.
| @@ -126,15 +127,44 @@ export class EndpointMeteringService { | |||
| }; | |||
| } | |||
|
|
|||
| private setType(config: ServerlessSecurityConfig) { | |||
There was a problem hiding this comment.
nit: If you rename it to pliType then this should also be renamed.
dasansol92
approved these changes
Aug 25, 2023
kibanamachine
added
v8.11.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates endpoint metering task to include cloud add-on. Tests to be added in follow up PR.
For maintainers