Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Show warning when all cases table reaches 10k cases message #164323

Merged
merged 13 commits into from
Aug 24, 2023
Merged

[Cases] Show warning when all cases table reaches 10k cases message #164323

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b3617df
add warning label when max cases limit reached
js-jankisalvi Aug 17, 2023
ccd0378
add unit tests
js-jankisalvi Aug 21, 2023
550065e
fix all cases unit tests
js-jankisalvi Aug 21, 2023
79f3864
add tests for button actions
js-jankisalvi Aug 21, 2023
f611c25
Merge remote-tracking branch 'upstream/main' into 10k-cases-message
js-jankisalvi Aug 23, 2023
11fded9
check pagesize
js-jankisalvi Aug 23, 2023
d1d349f
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Aug 23, 2023
27aaaf9
add check in all_cases list
js-jankisalvi Aug 23, 2023
25a5483
Merge branch '10k-cases-message' of https://github.com/js-jankisalvi/…
js-jankisalvi Aug 23, 2023
f69b714
Merge remote-tracking branch 'upstream/main' into 10k-cases-message
js-jankisalvi Aug 23, 2023
878b0f2
PR feedback
js-jankisalvi Aug 23, 2023
6c646d7
fix the translation title
js-jankisalvi Aug 23, 2023
b728fab
Fix translation check
js-jankisalvi Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,10 @@ describe('AllCasesListGeneric', () => {
expect(
screen.getAllByTestId('case-table-column-createdAt')[0].querySelector('.euiToolTipAnchor')
).toHaveTextContent(removeMsFromDate(useGetCasesMockState.data.cases[0].createdAt));
expect(screen.getByTestId('case-table-case-count')).toHaveTextContent('Showing 10 cases');
expect(screen.getByTestId('case-table-case-count')).toHaveTextContent(
`Showing 10 of ${useGetCasesMockState.data.total} cases`
);
expect(screen.queryByTestId('all-cases-maximum-limit-warning')).not.toBeInTheDocument();
});
});

Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/cases/public/components/all_cases/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export const CasesTable: FunctionComponent<CasesTableProps> = ({
) : (
<>
<CasesTableUtilityBar
pagination={pagination}
isSelectorView={isSelectorView}
totalCases={data.total ?? 0}
selectedCases={selectedCases}
Expand Down
22 changes: 19 additions & 3 deletions x-pack/plugins/cases/public/components/all_cases/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,28 @@ export const SHOWING_SELECTED_CASES = (totalRules: number) =>
defaultMessage: 'Selected {totalRules} {totalRules, plural, =1 {case} other {cases}}',
});

export const SHOWING_CASES = (totalRules: number) =>
export const SHOWING_CASES = (totalCases: number, pageSize: number) =>
i18n.translate('xpack.cases.caseTable.showingCasesTitle', {
values: { totalRules },
defaultMessage: 'Showing {totalRules} {totalRules, plural, =1 {case} other {cases}}',
values: { totalCases, pageSize },
defaultMessage:
'Showing {pageSize} of {totalCases} {totalCases, plural, =1 {case} other {cases}}',
});

export const MAX_CASES = (totalCases: number) =>
i18n.translate('xpack.cases.caseTable.maxCases', {
values: { totalCases },
defaultMessage:
'The results were capped at {totalCases} to maintain performance. Try limiting your search to reduce the results.',
});

export const DISMISS = i18n.translate('xpack.cases.caseTable.dismiss', {
defaultMessage: 'Dismiss',
});

export const NOT_SHOW_AGAIN = i18n.translate('xpack.cases.caseTable.notShowAgain', {
defaultMessage: 'Do not show again',
});

export const UNIT = (totalCount: number) =>
i18n.translate('xpack.cases.caseTable.unit', {
values: { totalCount },
Expand Down
Loading