[Cloud Security] Add AWS Org instructions #163952
Conversation
JordanSh
added
release_note:skip
JordanSh
changed the title
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @JordanSh |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
| <li> | ||
| <FormattedMessage | ||
| id="xpack.fleet.cloudFormation.guide.steps.organizationLogin" | ||
| defaultMessage="Log in as an admin in the management account of the AWS Organization you want to onboard" |
There was a problem hiding this comment.
any specific reason to have different wording here and in aws_credentials_form?
There was a problem hiding this comment.
I'm not sure, one is before the "save and continue" button is pressed, the others are for the modals and flyouts.
@tinnytintin10 @einatjacoby any particular reason for not keeping the texts the same? or should we open a follow up pr?
There was a problem hiding this comment.
I was just confused by the fact that for the Cloudformation option, two texts are identical Log in as an admin in the AWS account you want to onboard and Log in as an admin to the AWS Account you want to onboard (except the Account starting from a capital letter) and for the AWS Org texts differ but the meaning seems the same for me.
Not a big deal, I guess I just like consistency :)
There was a problem hiding this comment.
I'm 100% with you, I assume it was a mistake since those texts were changed last minute since the figma had some inaccuracies. I'll open a pr according to product decision.
Summary
Adding individual instructions based on account type
Before save instruction: AWS Org Account
Before save instruction: Single Account
Modal instructions (shared with flyout): AWS Org Account
Modal instructions (shared with flyout): Single Account
