[Security Solutions] Fix Serverless page title #163911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
force-pushed
the
157847_fix_page_title
branch
from
c44705c to
a34e9e6
Compare
machadoum
added
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: cc @machadoum |
|
Tested locally, LGTM! Thanks for fixing this Pablo 👍 |
angorayc
approved these changes
Aug 15, 2023
kibanamachine
added
v8.10.0
backport:skip
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Aug 16, 2023
## Summary Refactor useUpdateBrowserTitle to use pathname instead of SpyRoute ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
bryce-b
pushed a commit
that referenced
this pull request
Aug 22, 2023
## Summary Refactor useUpdateBrowserTitle to use pathname instead of SpyRoute ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #163664
Summary
Refactor useUpdateBrowserTitle to use pathname instead of SpyRoute
Checklist
Delete any items that are not applicable to this PR.