Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rules functional test by replacing uptime rule with metric threshold #163712

Merged

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Aug 11, 2023

Fixes #163427

Summary

Fix rules functional test by replacing uptime rule with a metric threshold as uptime is now replaced with synthetics (Why understand and solve an issue if we can remove it altogether?! :D)

Flaky test runner [100]: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2859

@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Aug 11, 2023
@maryam-saeidi maryam-saeidi self-assigned this Aug 11, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi marked this pull request as ready for review August 11, 2023 15:34
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner August 11, 2023 15:34
@maryam-saeidi maryam-saeidi merged commit 90b011c into elastic:main Aug 14, 2023
@maryam-saeidi maryam-saeidi deleted the 163427-fix-rules-functional-test branch August 14, 2023 12:52
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
5 participants