[Serverless] fix discover breadcrumbs missing search title

[Dosant]

Summary

Aaddress #163337 for discover saved search

Context:

In serverless navigation, we changed how breadcrumbs work. Instead of setting the full path manually, we automatically calculate the main parts of the path from the side nav + current URL. This was done to keep side nav and breadcrumbs in sync as much as possible and solve consistency issues with breadcrumbs across apps.
https://docs.elastic.dev/kibana-dev-docs/serverless-project-navigation#breadcrumbs

Apps can append custom deeper context using the serverless.setBreadcrumbs API. Regular core.chrome.setBreadcrumbs has no effect when the serverless nav is rendered.

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[davismcphee]

Tested locally and it looks to be working now, thanks! Would you mind adding a test for it though? Either a simple Jest test for discover_main_route.tsx to check that serverless.setBreadcrumbs is called or a Serverless functional test would be valuable IMO.

[Dosant]

Thanks @davismcphee, I've tried to add a unit test as you suggested, but I thought it was too much friction to mock all the needed states, and the tests for the whole component were too slow for adding a lot of separate breadcrumbs test cases.

Instead, I decided to conslidate all the setBreadcrumb calls in a single function and unit test that function. Hope this is fine.

[davismcphee]

Instead, I decided to conslidate all the setBreadcrumb calls in a single function and unit test that function. Hope this is fine.

That works for me, and the setBreadcrumbs function is a nice cleanup over the old approach anyway. Tested again and it's working as expected, LGTM and thanks for the fix + tests 👍

On a related note (although not due to this PR since it happens in main too), I just realized in testing again that when clicking the root Discover breadcrumb from the single doc or surrounding docs view, the Discover context is lost (e.g. filters, query, saved search, etc.). It looks like the breadcrumb always points to /app/discover#/ which clears our URL state and causes the lost context.

I can create a separate issue for this, but do you know if this is something that can be dealt with from the Discover side or something the Serverless nav code will have to handle?

[Dosant]

I just realized in testing again that when clicking the root Discover breadcrumb from the single doc or surrounding docs view, the Discover context is lost (e.g. filters, query, saved search, etc.). It looks like the breadcrumb always points to /app/discover#/ which clears our URL state and causes the lost context.

In serverless nav there is currently no way to do this by changing the href, I think it falls under #163488, I will add the use-case.
As a workaround, we could also consider keeping the state in-memory and then restore it

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a6031fa

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	557.4KB	557.4KB	+15.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
discover	31.4KB	31.5KB	+24.0B

History

• 💚 Build #149545 succeeded 5540eea
• 💛 Build #149225 was flaky 6058ec1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Dosant