[FTR] unskip tsvb time series tests for Chrome #163510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
release_note:skip
dmlemeshko
changed the title
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 10, 2023
## Summary Related to elastic#162995 This PR unskip TSVB tests for Chrome browser since it is proved to be stable https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836 100x passed https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835 100x passed On Firefox the flakiness is related to Terms 2nd aggregation field sometimes is not selected. I tested it manually in Firefox 116 and was able to set fields, though I have a feeling that values are not always selected on click in the drop-down. But I didn't see any errors in console. I also returned back retry for dropdown selection I removed in elastic#161202 though flaky-test-runner proves there is no need. Let's have just to keep logic as before my PR. (cherry picked from commit 072ad96)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 10, 2023
# Backport This will backport the following commits from `main` to `8.9`: - [[FTR] unskip tsvb time series tests for Chrome (#163510)](#163510) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-10T07:17:12Z","message":"[FTR] unskip tsvb time series tests for Chrome (#163510)\n\n## Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for Chrome browser since it is proved to be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation field\r\nsometimes is not selected. I tested it manually in Firefox 116 and was\r\nable to set fields, though I have a feeling that values are not always\r\nselected on click in the drop-down. But I didn't see any errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown selection I removed in #161202\r\nthough flaky-test-runner proves there is no need. Let's have just to\r\nkeep logic as before my PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.10.0","v8.9.1"],"number":163510,"url":"https://github.com/elastic/kibana/pull/163510","mergeCommit":{"message":"[FTR] unskip tsvb time series tests for Chrome (#163510)\n\n## Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for Chrome browser since it is proved to be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation field\r\nsometimes is not selected. I tested it manually in Firefox 116 and was\r\nable to set fields, though I have a feeling that values are not always\r\nselected on click in the drop-down. But I didn't see any errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown selection I removed in #161202\r\nthough flaky-test-runner proves there is no need. Let's have just to\r\nkeep logic as before my PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163510","number":163510,"mergeCommit":{"message":"[FTR] unskip tsvb time series tests for Chrome (#163510)\n\n## Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for Chrome browser since it is proved to be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation field\r\nsometimes is not selected. I tested it manually in Firefox 116 and was\r\nable to set fields, though I have a feeling that values are not always\r\nselected on click in the drop-down. But I didn't see any errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown selection I removed in #161202\r\nthough flaky-test-runner proves there is no need. Let's have just to\r\nkeep logic as before my PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #162995
This PR unskip TSVB tests for Chrome browser since it is proved to be stable
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836 100x passed
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835 100x passed
On Firefox the flakiness is related to Terms 2nd aggregation field sometimes is not selected. I tested it manually in Firefox 116 and was able to set fields, though I have a feeling that values are not always selected on click in the drop-down. But I didn't see any errors in console.
I also returned back retry for dropdown selection I removed in #161202 though flaky-test-runner proves there is no need. Let's have just to keep logic as before my PR.