Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry Schema Validation] Allow null on string #163499

Merged
merged 2 commits into from
Aug 10, 2023
Merged

[Telemetry Schema Validation] Allow null on string #163499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a89b7ec
[Telemetry Schema Validation] Allow `null` on `string`
afharo Aug 9, 2023
944fb2f
Merge branch 'main' into telemetry-schema-validation/allow-null-on-st…
dmlemeshko Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/kbn-telemetry-tools/src/schema_ftr_validations/schema_to_config_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ function valueSchemaToConfigSchema(value: TelemetrySchemaValue): Type<unknown> {
case 'keyword':
case 'text':
case 'date':
return schema.string();
// Some plugins return `null` when there is no value to report
return schema.oneOf([schema.string(), schema.literal(null)]);
case 'byte':
case 'double':
case 'float':
Expand Down
Loading