-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions] Add upselling service to security solutions ESS plugin #163406
Conversation
3e7a344
to
6e560ac
Compare
c36a947
to
a568723
Compare
03d02d7
to
6a36e2b
Compare
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
x-pack/plugins/security_solution/public/common/lib/upsellings/upselling_service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defend workflows lgtm 👍
x-pack/plugins/security_solution_serverless/public/upselling/register_upsellings.tsx
Outdated
Show resolved
Hide resolved
d2eea11
to
99ed4cf
Compare
x-pack/plugins/security_solution_serverless/public/upselling/register_upsellings.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/common/lib/upsellings/upselling_service.ts
Outdated
Show resolved
Hide resolved
Thanks for catching this @michaelolo24! I think the bug was introduced when #163102 got merged. I pushed a fix. Could you please take a second look? |
ec104f7
to
6804076
Compare
6804076
to
82cc135
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @machadoum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the bug! Works great. Nice work 👌🏾 🚀
…plugin (#163406) ## Summary * Use Serverless upsell architecture on ESS. But check for the required license instead of capabilities. * Covert Investigation Guide and Entity Analytics upsell to the new architecture. * Update upsell registering functions always to clear the state when registering a new value. It fits perfectly ESS because the license is observable. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
related to elastic/pull/163406
Summary
Checklist