Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solutions] Add upselling service to security solutions ESS plugin #163406

Merged
merged 15 commits into from
Aug 16, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Aug 8, 2023

Summary

  • Use Serverless upsell architecture on ESS. But check for the required license instead of capabilities.
  • Covert Investigation Guide and Entity Analytics upsell to the new architecture.
  • Update upsell registering functions always to clear the state when registering a new value. It fits perfectly ESS because the license is observable.

Checklist

@machadoum machadoum changed the title Add upselling service to security solutions ESS plugin [Security Solutions] Add upselling service to security solutions ESS plugin Aug 9, 2023
@machadoum machadoum force-pushed the upselling-for-ess branch 2 times, most recently from c36a947 to a568723 Compare August 9, 2023 12:36
@machadoum machadoum self-assigned this Aug 9, 2023
@machadoum machadoum added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture labels Aug 9, 2023
@machadoum machadoum force-pushed the upselling-for-ess branch 3 times, most recently from 03d02d7 to 6a36e2b Compare August 10, 2023 11:01
@machadoum machadoum marked this pull request as ready for review August 10, 2023 11:34
@machadoum machadoum requested review from a team as code owners August 10, 2023 11:34
@machadoum machadoum requested review from joeypoon and tomsonpl August 10, 2023 11:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defend workflows lgtm 👍

@machadoum machadoum force-pushed the upselling-for-ess branch 2 times, most recently from d2eea11 to 99ed4cf Compare August 11, 2023 08:28
@michaelolo24
Copy link
Contributor

Hey, the code looks great, but I'm running into this error when trying to load the entity analytics page on a basic license. I threw a console.log in useNavigationContext and you can see in the console that just before the page is loaded, services is reset to null. Not sure why this is happening yet, but everything else seems to work fine. I also cleared everything in my browser storage in case that was affecting it somehow, but still shows up

image

@machadoum
Copy link
Member Author

Hey, the code looks great, but I'm running into this error when trying to load the entity analytics page on a basic license. I threw a console.log in useNavigationContext and you can see in the console that just before the page is loaded, services is reset to null. Not sure why this is happening yet, but everything else seems to work fine. I also cleared everything in my browser storage in case that was affecting it somehow, but still shows up

image

Thanks for catching this @michaelolo24! I think the bug was introduced when #163102 got merged. I pushed a fix. Could you please take a second look?

@machadoum machadoum force-pushed the upselling-for-ess branch 3 times, most recently from ec104f7 to 6804076 Compare August 16, 2023 12:15
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #1 / Endpoint Policy Response from Endpoint List page should display policy response with errors should display policy response with errors
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #5 / Isolate command From cases should isolate and release host should isolate and release host

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4441 4438 -3
securitySolutionEss 15 101 +86
securitySolutionServerless 409 410 +1
total +84

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB -4.3KB
securitySolutionEss 5.1KB 42.0KB +37.0KB
securitySolutionServerless 255.3KB 255.3KB -20.0B
total +32.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 62.4KB 62.5KB +76.0B
securitySolutionEss 4.1KB 8.0KB +3.9KB
securitySolutionServerless 37.9KB 37.9KB +10.0B
total +4.0KB
Unknown metric groups

async chunk count

id before after diff
securitySolutionEss 1 2 +1

ESLint disabled line counts

id before after diff
securitySolutionEss 5 6 +1
securitySolutionServerless 35 34 -1
total -0

miscellaneous assets size

id before after diff
securitySolution 4.0MB 1.8MB -2.2MB
securitySolutionEss 2.0MB 4.4MB ⚠️ +2.3MB
total +161.8KB

Total ESLint disabled count

id before after diff
securitySolutionEss 5 6 +1
securitySolutionServerless 35 34 -1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bug! Works great. Nice work 👌🏾 🚀

@machadoum machadoum merged commit 5b2859f into elastic:main Aug 16, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 16, 2023
bryce-b pushed a commit that referenced this pull request Aug 22, 2023
…plugin (#163406)

## Summary

* Use Serverless upsell architecture on ESS. But check for the required
license instead of capabilities.
* Covert Investigation Guide and Entity Analytics upsell to the new
architecture.
* Update upsell registering functions always to clear the state when
registering a new value. It fits perfectly ESS because the license is
observable.
### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants