Fix assertions against toasts in Dashboard and Discover functional tests. #16336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
v7.0.0
v6.3.0
Feature:Dashboard
💔 Build Failed |
cjcenizal
force-pushed
the
functional-test-fix-toast-assertions
branch
from
e8ba735 to
6292f12
Compare
💚 Build Succeeded |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jan 29, 2018
cjcenizal
added a commit
that referenced
this pull request
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15749 I made adjustments to the functional test page objects so that they'd check for the existence of various toasts. However, I forgot to update the assertions in the tests themselves which consumed these page objects, so that they'd still be actually asserting something. This PR fixes that.