[Security Solution] Prebuilt rule installation / upgrade flyout #163304

nikitaindik · 2023-08-07T14:13:35Z

Addresses: #162334

Summary

This PR adds a flyout for viewing a prebuilt rule before installing or updating it. The flyout can be opened by clicking on a rule title within "Add Elastic Rules" page and within "Rule Updates" tab of the Rule Managament table.

I plan to add tests and do minor visual tweaks after the FF.

An additional goal of these changes was to create lightweight reusable components for rule details sections ("About", "Definition", "Schedule") and for rule properties, so that these can later be reused in other flyouts within the Security Solution, on MITRE ATT&CK™ overview page and potentially on the Rule Details page.
These reusable section components are basically copy-pasted components from the Rule Details page that were refactored to remove the dependence from the form schema,

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

elasticmachine · 2023-08-14T07:14:32Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2023-08-14T07:14:32Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

xcrzx · 2023-08-14T09:38:44Z

Kibana crashes when switching to a rule without the "Investigation Guide" section:

Screen.Recording.2023-08-14.at.11.37.15.mov

xcrzx · 2023-08-14T09:46:37Z

@nikitaindik, could you please fix the paddings and spacings so that they match the original design more closely?

Design:

Implementation:

Design:

Implementation:

xcrzx · 2023-08-14T10:30:07Z

Some rule information is not shown on the flyout, like rule query, for example:

The same rule is on the rule details page:

xcrzx · 2023-08-14T11:11:00Z

@nikitaindik On the rule update page, we display the currently installed version of a rule in the update flyout, not the updated one. Is this intended? It seems the flyout should show the forthcoming version with all updates instead of the existing rule state.

xcrzx · 2023-08-14T11:15:07Z

If I remember correctly, we wanted to hide the "Run job" toggle from the rule preview. Has the decision changed?

nkhristinin

I didn't test locally, I just reviewed 2 files owned by @elastic/security-detection-engine

Left some comments, which can be addressed after FF

x-pack/plugins/security_solution/common/detection_engine/diffable_rule_to_rule_response.ts

x-pack/plugins/security_solution/common/api/detection_engine/model/rule_schema/rule_schemas.ts

banderror · 2023-08-15T11:39:37Z

@nikitaindik Could you rebase the PR? It's getting too far behind main

xcrzx · 2023-08-15T11:42:44Z

...ment_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table_context.tsx

+   * (e.g. when the rule is already being installed or when the table is being refetched)
+   *
+   **/
+  isFlyoutInstallButtonDisabled: boolean;


Data contexts should not be aware of any UI elements that are consuming them. We should choose a name for this prop that's both neutral and generic, so it can be used in components beyond just the button inside a flyout.

++ Maybe we could call it canPreviewedRuleBeInstalled or something like that.

xcrzx · 2023-08-15T11:45:44Z

...ment_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table_context.tsx

@@ -77,6 +88,8 @@ export interface AddPrebuiltRulesTableActions {
  installSelectedRules: () => void;
  setFilterOptions: Dispatch<SetStateAction<AddPrebuiltRulesTableFilterOptions>>;
  selectRules: (rules: RuleInstallationInfoForReview[]) => void;
+  openFlyoutForRuleId: (ruleId: RuleSignatureId) => void;


Same here: openFlyoutForRuleId -> openRulePreview

xcrzx · 2023-08-15T11:54:57Z

...ment_ui/components/rules_table/upgrade_prebuilt_rules_table/upgrade_prebuilt_rules_table.tsx

@@ -118,6 +119,8 @@ export const UpgradePrebuiltRulesTable = React.memo(() => {
                data-test-subj="rules-upgrades-table"
                columns={rulesColumns}
              />
+
+              <UpgradePrebuiltRulesFlyout />


Let's move this component to the context provider. The table should not be aware of the flyout.

xcrzx · 2023-08-15T11:55:37Z

...e_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx

@@ -95,6 +97,8 @@ export const AddPrebuiltRulesTable = React.memo(() => {
                data-test-subj="add-prebuilt-rules-table"
                columns={rulesColumns}
              />
+
+              <AddPrebuiltRulesFlyout />


Same: Let's move this component to the context provider. The table should not be aware of the flyout.

xcrzx · 2023-08-15T11:59:43Z

...ment_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table_context.tsx

@@ -77,6 +88,8 @@ export interface AddPrebuiltRulesTableActions {
  installSelectedRules: () => void;
  setFilterOptions: Dispatch<SetStateAction<AddPrebuiltRulesTableFilterOptions>>;
  selectRules: (rules: RuleInstallationInfoForReview[]) => void;
+  openFlyoutForRuleId: (ruleId: RuleSignatureId) => void;
+  closeFlyout: () => void;


I think we need to make properties like flyoutRule and closeFlyout internal for this context. Components outside don't need to know anything about how a rule is displayed. We can encapsulate this knowledge inside the context and expose only a generic method, like openRulePreview(ruleId).

xcrzx · 2023-08-15T12:04:51Z

...tion/public/detection_engine/rule_management/components/rule_details/rule_details_flyout.tsx

+  actionButtonLabel: string;
+  isActionButtonDisabled: boolean;
+  onActionButtonClick: (ruleId: string) => void;


As discussed on a zoom call, let's replace these props with a more generic action: React.ReactNode

xcrzx · 2023-08-15T12:07:21Z

.../public/detection_engine/rule_management/components/rule_details/rule_definition_section.tsx

We need to reuse the extracted components on the rule details page as well.

xcrzx · 2023-08-15T12:26:07Z

...ity_solution/public/detection_engine/rule_management/components/rule_details/translations.ts

+export const BUILDING_BLOCK_FIELD_LABEL = i18n.translate(
+  'xpack.securitySolution.detectionEngine.ruleDetails.buildingBlockFieldLabel',
+  {
+    defaultMessage: 'Building block',
+  }
+);
+
+export const BUILDING_BLOCK_FIELD_DESCRIPTION = i18n.translate(
+  'xpack.securitySolution.detectionEngine.ruleDetails.buildingBlockFieldDescription',
+  {
+    defaultMessage: 'All generated alerts will be marked as "building block" alerts',
+  }
+);


Can we reuse the existing translations for all these fields?

xcrzx · 2023-08-15T12:29:34Z

.../public/detection_engine/rule_management/components/rule_details/use_rule_details_flyout.tsx

+      invariant(ruleToShowInFlyout, `Rule with id ${ruleId} not found`);
+      if (ruleToShowInFlyout) {


ruleToShowInFlyout cannot be undefined after checking the invariant on the previous line.

xcrzx · 2023-08-15T12:32:39Z

...tion/public/detection_engine/rule_management/components/rule_details/rule_details_flyout.tsx

+  }
+`;
+
+const StyledEuiTabbedContent = styled(EuiTabbedContent)`


It's a full copy of StyledEuiTabbedContent from components/event_details/event_details.tsx. Please reuse components whenever possible instead of copying them.

kibana-ci · 2023-08-15T13:41:28Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 9c530ab

Failed CI Steps

FTR Configs #65

Test Failures

[job] [logs] FTR Configs #65 / endpoint For each artifact list under management "after all" hook in "For each artifact list under management"
[job] [logs] FTR Configs #65 / endpoint For each artifact list under management "before all" hook in "For each artifact list under management"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	4416	4429	+13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	15.6MB	15.6MB	+24.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	62.2KB	62.4KB	+153.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	465	466	+1

Total ESLint disabled count

id	before	after	diff
`securitySolution`	531	532	+1

History

💚 Build #149923 succeeded 8ee5ffd
💔 Build #149910 failed 7bf4be548d3d17b31c7087f6c9646575d6c9cbf8
💔 Build #149899 failed a0cb667fec7d75a29ede72a12371dacab73a919f
💔 Build #149831 failed d639806d5abc163a943d5c8948075a134862ba3b
💔 Build #149825 failed 23dd003c0245934ac7a7a55afa22c08e9f07a2e3
💔 Build #147964 failed b83040dda2d49eb48ab5ff0acbcce425e78fe2b7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nikitaindik

xcrzx

Thanks for your effort, Nikita 👍 Our users are really going to appreciate this new feature 🎉

I've gone through the PR locally, and the new workflow works smoothly. Let's proceed with the merge. Any remaining feedback isn't urgent and can be addressed in a follow-up PR. Could you summarize the remaining tasks somewhere, please?

Also, I'd love to dive deeper into the context usage and discuss potential improvements.

…tic#163304) **Addresses:** elastic#162334 ## Summary This PR adds a flyout for viewing a prebuilt rule before installing or updating it. The flyout can be opened by clicking on a rule title within "Add Elastic Rules" page and within "Rule Updates" tab of the Rule Managament table. I plan to add tests and do minor visual tweaks after the FF. <img width="1269" alt="Screenshot 2023-08-14 at 03 59 30" src="https://github.com/elastic/kibana/assets/15949146/c8200ff8-fbe2-445a-a03e-3545ea77f750"> An additional goal of these changes was to create lightweight reusable components for rule details sections ("About", "Definition", "Schedule") and for rule properties, so that these can later be reused in other flyouts within the Security Solution, on MITRE ATT&CK™ overview page and potentially on the Rule Details page. These reusable section components are basically copy-pasted components from the Rule Details page that were refactored to remove the dependence from the form schema, ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

banderror

Sorry @nikitaindik, I'm a bit late with this review, but still wanted to share some suggestions I had after going through the diff.

I also tested how the flyout works in both tables, I think it looks great! One thing I noticed is that it feels like it takes more than 100ms to render it for the first time (when it's closed), so maybe we could also look into improving the rendering performance.

Thank you for your efforts!

banderror · 2023-08-16T17:21:57Z

.../public/detection_engine/rule_management/components/rule_details/use_rule_details_flyout.tsx

+export const useRuleDetailsFlyout = (
+  rules: DiffableRule[]
+): RuleDetailsFlyoutState & RuleDetailsFlyoutActions => {
+  const [flyoutRule, setFlyoutRule] = React.useState<RuleInstallationInfoForReview | null>(null);


This hook, given it knows about RuleInstallationInfoForReview, either should not be here in the rule_management subdomain, or should be somehow rewritten to remove this dependency. I lean towards just moving it closer to the rule installation table's React context.

Same for the upgrade table's context. But I think there we'd need a slightly modified version of this function (see my next comment about using ruleId: RuleSignatureId).

banderror · 2023-08-16T17:26:34Z

.../public/detection_engine/rule_management/components/rule_details/use_rule_details_flyout.tsx

+  const openFlyoutForRuleId = useCallback(
+    (ruleId: RuleSignatureId) => {
+      const ruleToShowInFlyout = rules.find((rule) => rule.rule_id === ruleId);


This is the only way to find rules that are not installed yet - they only have this RuleSignatureId. For the rule upgrade table, I think a better way would be finding rules by their RuleObjectId. Signature ids sometimes can be duplicated in multiple rules.

Also I think a hook for the upgrade table shouldn't depend on the RuleInstallationInfoForReview type. There's a RuleUpgradeInfoForReview type which is used in UpgradePrebuiltRulesTableContextProvider.

banderror · 2023-08-16T17:37:43Z

..._management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_flyout.tsx

+    return null;
+  }
+
+  const ruleResponse: Partial<RuleResponse> = diffableRuleToRuleResponse(flyoutRule);


Shouldn't this be memoized? The conversion could be expensive in terms of rendering time -- if it's tens of milliseconds it would be perceivable by users.

I know we're going to change the two API endpoints to return RuleResponse, so no conversion will be needed, but still wanted to pay attention to this.

banderror · 2023-08-16T17:51:21Z

...ment_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table_context.tsx

+   * (e.g. when the rule is already being installed or when the table is being refetched)
+   *
+   **/
+  isFlyoutInstallButtonDisabled: boolean;


++ Maybe we could call it canPreviewedRuleBeInstalled or something like that.

) **Addresses:** #162334 ## Summary This PR adds a flyout for viewing a prebuilt rule before installing or updating it. The flyout can be opened by clicking on a rule title within "Add Elastic Rules" page and within "Rule Updates" tab of the Rule Managament table. I plan to add tests and do minor visual tweaks after the FF. <img width="1269" alt="Screenshot 2023-08-14 at 03 59 30" src="https://github.com/elastic/kibana/assets/15949146/c8200ff8-fbe2-445a-a03e-3545ea77f750"> An additional goal of these changes was to create lightweight reusable components for rule details sections ("About", "Definition", "Schedule") and for rule properties, so that these can later be reused in other flyouts within the Security Solution, on MITRE ATT&CK™ overview page and potentially on the Rule Details page. These reusable section components are basically copy-pasted components from the Rule Details page that were refactored to remove the dependence from the form schema, ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

…ovements (#164179) **Addresses: #162334 **Base PR: #163304 <img width="1177" alt="Screenshot 2023-08-24 at 04 09 07" src="https://github.com/elastic/kibana/assets/15949146/73ac6726-69d4-4c46-bb16-da704a02aba5"> ## Summary This is a follow-up refactoring and bugfix PR to improve the prebuilt rules flyout. Base PR: #163304 #### Changes - [x] Tweak UI so that it matches the design more closely. [Design](https://www.figma.com/file/gLHm8LpTtSkAUQHrkG3RHU/%5B8.7%5D-%5BRules%5D-Rule-Immutability%2FCustomization?type=design&node-id=3563-612771&mode=design&t=yqZ6LI0vAjbir9xc-0) (external). - [x] Rewrite preview installation and upgrade API endpoints to respond with `RuleResponse` instead of `DiffableRule` - [x] Revert some changes introduced by this [PR](#163304) - [x] Revert exports in `x-pack/plugins/security_solution/common/api/detection_engine/model/rule_schema/rule_schemas.ts` - [x] Delete `x-pack/plugins/security_solution/common/detection_engine/diffable_rule_to_rule_response.ts` - [x] Make the data contexts unaware of any UI elements that are consuming them - [x] Move rendering of specialized flyout components into to the context provider so that the table is unaware of the flyout. - [x] Make "flyoutRule" and "closeFlyout" internal to the context. Components outside don't need to know anything about how a rule is displayed. We can encapsulate this knowledge inside the context and expose only a generic method, like openRulePreview(ruleId) - [x] Remove unnecessary checks after using "invariant" - [x] Make sure query, timeline template and all the other fields are shown in the flyout. Compare each rule in a flyout with the Rule Details to ensure that all fields are in place. - [x] Remove the enable / disable switch machine learning job UI switch element - [x] Add custom highlighted fields to the flyout ([comment](#163235 (comment))) ### Checklist Delete any items that are not applicable to this PR. - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials. [Docs ticket](elastic/security-docs#3798) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

…ovements (elastic#164179) **Addresses: elastic#162334 **Base PR: elastic#163304 <img width="1177" alt="Screenshot 2023-08-24 at 04 09 07" src="https://github.com/elastic/kibana/assets/15949146/73ac6726-69d4-4c46-bb16-da704a02aba5"> ## Summary This is a follow-up refactoring and bugfix PR to improve the prebuilt rules flyout. Base PR: elastic#163304 #### Changes - [x] Tweak UI so that it matches the design more closely. [Design](https://www.figma.com/file/gLHm8LpTtSkAUQHrkG3RHU/%5B8.7%5D-%5BRules%5D-Rule-Immutability%2FCustomization?type=design&node-id=3563-612771&mode=design&t=yqZ6LI0vAjbir9xc-0) (external). - [x] Rewrite preview installation and upgrade API endpoints to respond with `RuleResponse` instead of `DiffableRule` - [x] Revert some changes introduced by this [PR](elastic#163304) - [x] Revert exports in `x-pack/plugins/security_solution/common/api/detection_engine/model/rule_schema/rule_schemas.ts` - [x] Delete `x-pack/plugins/security_solution/common/detection_engine/diffable_rule_to_rule_response.ts` - [x] Make the data contexts unaware of any UI elements that are consuming them - [x] Move rendering of specialized flyout components into to the context provider so that the table is unaware of the flyout. - [x] Make "flyoutRule" and "closeFlyout" internal to the context. Components outside don't need to know anything about how a rule is displayed. We can encapsulate this knowledge inside the context and expose only a generic method, like openRulePreview(ruleId) - [x] Remove unnecessary checks after using "invariant" - [x] Make sure query, timeline template and all the other fields are shown in the flyout. Compare each rule in a flyout with the Rule Details to ensure that all fields are in place. - [x] Remove the enable / disable switch machine learning job UI switch element - [x] Add custom highlighted fields to the flyout ([comment](elastic#163235 (comment))) ### Checklist Delete any items that are not applicable to this PR. - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials. [Docs ticket](elastic/security-docs#3798) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit c115f5d) # Conflicts: # x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/review_rule_installation/review_rule_installation_route.ts

…ut improvements (#164179) (#164897) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Prebuilt rules installation / upgrade flyout improvements (#164179)](#164179)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Nikita Indik <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]>

maximpn mentioned this pull request Aug 8, 2023

[Security Solution] Expandable flyout - Rule preview contents #163027

Merged

2 tasks

banderror assigned nikitaindik Aug 9, 2023

nikitaindik force-pushed the prebuilt-rules-flyout branch from 23dd003 to d639806 Compare August 11, 2023 22:41

nikitaindik added 5 commits August 14, 2023 08:46

WIP

6bfa0e6

Refactor

33b48b5

Fix types

97944d6

A small refactor

f438cb2

Type fix

8ee5ffd

nikitaindik force-pushed the prebuilt-rules-flyout branch from 7bf4be5 to 8ee5ffd Compare August 14, 2023 06:46

nikitaindik marked this pull request as ready for review August 14, 2023 07:09

nikitaindik requested review from a team as code owners August 14, 2023 07:09

nikitaindik requested a review from xcrzx August 14, 2023 07:09

nikitaindik added the release_note:feature Makes this part of the condensed release notes label Aug 14, 2023

nkhristinin approved these changes Aug 15, 2023

View reviewed changes

x-pack/plugins/security_solution/common/detection_engine/diffable_rule_to_rule_response.ts Show resolved Hide resolved

x-pack/plugins/security_solution/common/detection_engine/diffable_rule_to_rule_response.ts Show resolved Hide resolved

nkhristinin reviewed Aug 15, 2023

View reviewed changes

x-pack/plugins/security_solution/common/api/detection_engine/model/rule_schema/rule_schemas.ts Show resolved Hide resolved

nikitaindik added 3 commits August 15, 2023 14:36

Style fixes and minor refactorings

55066cf

Make ESLint happy

e84e93c

Merge branch 'main' into prebuilt-rules-flyout

9c530ab

xcrzx reviewed Aug 15, 2023

View reviewed changes

xcrzx approved these changes Aug 15, 2023

View reviewed changes

nikitaindik merged commit 07312bf into elastic:main Aug 15, 2023

kibanamachine added the backport:skip This commit does not require backporting label Aug 15, 2023

banderror mentioned this pull request Aug 15, 2023

[Security Solution] Implement a rule details flyout for installing and upgrading prebuilt rules #162334

Closed

15 tasks

banderror reviewed Aug 16, 2023

View reviewed changes

nikitaindik mentioned this pull request Aug 17, 2023

[Security Solution] Prebuilt rules installation / upgrade flyout improvements #164179

Merged

16 tasks

nikitaindik mentioned this pull request Aug 23, 2023

[DOCS] Document the new prebuilt rule installation / upgrade flyout elastic/security-docs#3798

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Prebuilt rule installation / upgrade flyout #163304

[Security Solution] Prebuilt rule installation / upgrade flyout #163304

nikitaindik commented Aug 7, 2023 •

edited

Loading

elasticmachine commented Aug 14, 2023

elasticmachine commented Aug 14, 2023

xcrzx commented Aug 14, 2023

xcrzx commented Aug 14, 2023

xcrzx commented Aug 14, 2023

xcrzx commented Aug 14, 2023

xcrzx commented Aug 14, 2023

nkhristinin left a comment

banderror commented Aug 15, 2023

xcrzx Aug 15, 2023

banderror Aug 16, 2023

xcrzx Aug 15, 2023

xcrzx Aug 15, 2023

xcrzx Aug 15, 2023

xcrzx Aug 15, 2023

xcrzx Aug 15, 2023

xcrzx Aug 15, 2023

xcrzx Aug 15, 2023

xcrzx Aug 15, 2023

xcrzx Aug 15, 2023

kibana-ci commented Aug 15, 2023

ESLint disabled line counts

Total ESLint disabled count

xcrzx left a comment

banderror left a comment

banderror Aug 16, 2023

banderror Aug 16, 2023

banderror Aug 16, 2023

banderror Aug 16, 2023

		invariant(ruleToShowInFlyout, `Rule with id ${ruleId} not found`);
		if (ruleToShowInFlyout) {

[Security Solution] Prebuilt rule installation / upgrade flyout #163304

[Security Solution] Prebuilt rule installation / upgrade flyout #163304

Conversation

nikitaindik commented Aug 7, 2023 • edited Loading

Summary

Checklist

elasticmachine commented Aug 14, 2023

elasticmachine commented Aug 14, 2023

xcrzx commented Aug 14, 2023

xcrzx commented Aug 14, 2023

xcrzx commented Aug 14, 2023

xcrzx commented Aug 14, 2023

xcrzx commented Aug 14, 2023

nkhristinin left a comment

Choose a reason for hiding this comment

banderror commented Aug 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibana-ci commented Aug 15, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

xcrzx left a comment

Choose a reason for hiding this comment

banderror left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikitaindik commented Aug 7, 2023 •

edited

Loading