-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detection Engine][Rules] - Adds custom highlighted fields option #163235
Merged
Merged
Changes from 30 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
eb33083
trying to recreate changes for new custom highlighted fields
yctercero 0b98a19
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero 110eb99
got most of the code ported over
yctercero 5a249b9
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero ccf1c24
adding back in tests and cleanup
yctercero cbbbbf9
continued cleanup
yctercero 6f5ac58
cleanup and making by default additive
yctercero f416282
cleaning up types
yctercero a42910e
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero 888c042
updating so now everywhere pulls latest custom highlighted fields
yctercero b8c3923
dont need to map it in alert since always accessing latest
yctercero b272000
continued cleanup
yctercero 7b97501
continued cleanup
yctercero eda33ef
continued cleanup
yctercero 5920bba
trying to fix tests
yctercero 317873d
trying to fix tests
yctercero 0363fb8
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero e0b6a90
trying to fix tests
yctercero bfda622
trying to fix tests
yctercero 44aa7a5
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero 013c437
cleanup, cleanup, everybody cleanup
yctercero 7376b1b
addressing PR feedback
yctercero 07d0e41
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero 2fd6f51
updated jest test and linting issue
yctercero a7379e5
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine df9d604
working on cypress tests and renaming field to investigation_fields
yctercero 3f67bc5
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero ba11dba
Merge branch 'custom_highlighted_fields' of github.com:yctercero/kiba…
yctercero 97d5adf
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 2188d0d
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine e0f8fc9
adding to older event details flyout after refactor
yctercero a416d1a
Merge branch 'custom_highlighted_fields' of github.com:yctercero/kiba…
yctercero 5a225bf
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero 49bdfc0
skipping flakey tests, linked to issue as required follow up for release
yctercero 2d01586
some cleanup
yctercero 294387d
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero 9d6c1e3
Merge branch 'main' into custom_highlighted_fields
kibanamachine f62deca
Merge branch 'main' of github.com:elastic/kibana into custom_highligh…
yctercero e3b8078
trying to get ci to pass
yctercero 983053e
Merge branch 'custom_highlighted_fields' of github.com:yctercero/kiba…
yctercero 9cc5c9f
Merge branch 'main' into custom_highlighted_fields
kibanamachine d547c5e
Merge branch 'main' into custom_highlighted_fields
MadameSheema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please add a JSDoc comment with an explanation what these fields mean and a link to the PR?