[data views] Disable scripted fields in serverless environment

src/plugins/data/common/search/search_source/create_search_source.test.ts

@@ -23,6 +23,7 @@ describe('createSearchSource', () => {
       getConfig: jest.fn(),
       search: jest.fn(),
       onResponse: (req, res) => res,
+      scriptedFieldsEnabled: true,
     };
 
     indexPatternContractMock = {

src/plugins/data/common/search/search_source/mocks.ts

@@ -71,4 +71,5 @@ export const createSearchSourceMock = (
         )
       ),
     onResponse: jest.fn().mockImplementation((req, res) => res),
+    scriptedFieldsEnabled: true,
   });

src/plugins/data/common/search/search_source/search_source.test.ts

@@ -94,6 +94,7 @@ describe('SearchSource', () => {
       getConfig: getConfigMock,
       search: mockSearchMethod,
       onResponse: jest.fn().mockImplementation((_, res) => res),
+      scriptedFieldsEnabled: true,
     };
 
     searchSource = new SearchSource({}, searchSourceDependencies);

src/plugins/data/common/search/search_source/search_source.ts

@@ -138,6 +138,7 @@ export const searchSourceRequiredUiSettings = [
 export interface SearchSourceDependencies extends FetchHandlers {
   aggs: AggsStart;
   search: ISearchGeneric;
+  scriptedFieldsEnabled: boolean;
 }
 
 interface ExpressionAstOptions {
@@ -798,10 +799,13 @@ export class SearchSource {
     // set defaults
     let fieldsFromSource = searchRequest.fieldsFromSource || [];
     body.fields = body.fields || [];
-    body.script_fields = {
-      ...body.script_fields,
-      ...scriptFields,
-    };
+
+    if (this.dependencies.scriptedFieldsEnabled) {
+      body.script_fields = {
+        ...body.script_fields,
+        ...scriptFields,
+      };
+    }
     body.stored_fields = storedFields;
     body.runtime_mappings = runtimeFields || {};
 

src/plugins/data/common/search/search_source/search_source_service.test.ts

@@ -19,6 +19,7 @@ describe('SearchSource service', () => {
       getConfig: jest.fn(),
       search: jest.fn(),
       onResponse: jest.fn(),
+      scriptedFieldsEnabled: true,
     };
   });
 

src/plugins/data/public/plugin.ts

@@ -138,6 +138,7 @@ export class DataPublicPlugin
       fieldFormats,
       indexPatterns: dataViews,
       screenshotMode,
+      scriptedFieldsEnabled: dataViews.scriptedFieldsEnabled,
     });
     setSearchService(search);
 

src/plugins/data/public/search/search_service.test.ts

@@ -69,6 +69,7 @@ describe('Search service', () => {
         fieldFormats: {} as FieldFormatsStart,
         indexPatterns: {} as DataViewsContract,
         screenshotMode: screenshotModePluginMock.createStartContract(),
+        scriptedFieldsEnabled: true,
       });
     });
 

src/plugins/data/public/search/search_service.ts

@@ -86,6 +86,7 @@ export interface SearchServiceStartDependencies {
   fieldFormats: FieldFormatsStart;
   indexPatterns: DataViewsContract;
   screenshotMode: ScreenshotModePluginStart;
+  scriptedFieldsEnabled: boolean;
 }
 
 export class SearchService implements Plugin<ISearchSetup, ISearchStart> {
@@ -216,7 +217,12 @@ export class SearchService implements Plugin<ISearchSetup, ISearchStart> {
 
   public start(
     { http, theme, uiSettings, chrome, application }: CoreStart,
-    { fieldFormats, indexPatterns, screenshotMode }: SearchServiceStartDependencies
+    {
+      fieldFormats,
+      indexPatterns,
+      screenshotMode,
+      scriptedFieldsEnabled,
+    }: SearchServiceStartDependencies
   ): ISearchStart {
     const search = ((request, options = {}) => {
       return this.searchInterceptor.search(request, options);
@@ -245,6 +251,7 @@ export class SearchService implements Plugin<ISearchSetup, ISearchStart> {
         }
         return response;
       },
+      scriptedFieldsEnabled,
     };
 
     const config = this.initializerContext.config.get();

src/plugins/data/server/search/search_service.ts

@@ -302,6 +302,7 @@ export class SearchService implements Plugin<ISearchSetup, ISearchStart> {
             getConfig: <T = any>(key: string): T => uiSettingsCache[key],
             search: this.asScoped(request).search,
             onResponse: (req, res) => res,
+            scriptedFieldsEnabled: true,
           };
 
           return this.searchSourceService.start(scopedIndexPatterns, searchSourceDependencies);

src/plugins/data_view_management/public/components/edit_index_pattern/tabs/tabs.tsx

@@ -569,15 +569,15 @@ export function Tabs({
 
   const euiTabs: EuiTabbedContentTab[] = useMemo(
     () =>
-      getTabs(indexPattern, fieldFilter, relationships.length).map(
+      getTabs(indexPattern, fieldFilter, relationships.length, dataViews.scriptedFieldsEnabled).map(
         (tab: Pick<EuiTabbedContentTab, 'name' | 'id'>) => {
           return {
             ...tab,
             content: getContent(tab.id),
           };
         }
       ),
-    [fieldFilter, getContent, indexPattern, relationships]
+    [fieldFilter, getContent, indexPattern, relationships, dataViews.scriptedFieldsEnabled]
   );
 
   const [selectedTabId, setSelectedTabId] = useState(euiTabs[0].id);

src/plugins/data_view_management/public/components/edit_index_pattern/tabs/utils.ts

@@ -73,7 +73,12 @@ function getTitle(type: string, filteredCount: Dictionary<number>, totalCount: D
   return title + count;
 }
 
-export function getTabs(indexPattern: DataView, fieldFilter: string, relationshipCount = 0) {
+export function getTabs(
+  indexPattern: DataView,
+  fieldFilter: string,
+  relationshipCount = 0,
+  scriptedFieldsEnabled: boolean
+) {
   const totalCount = getCounts(indexPattern.fields.getAll(), indexPattern.getSourceFiltering());
   const filteredCount = getCounts(
     indexPattern.fields.getAll(),
@@ -89,7 +94,7 @@ export function getTabs(indexPattern: DataView, fieldFilter: string, relationshi
     'data-test-subj': 'tab-indexedFields',
   });
 
-  if (areScriptedFieldsEnabled(indexPattern)) {
+  if (areScriptedFieldsEnabled(indexPattern) && scriptedFieldsEnabled) {
     tabs.push({
       name: getTitle('scripted', filteredCount, totalCount),
       id: TAB_SCRIPTED_FIELDS,

src/plugins/data_view_management/public/components/utils.ts

@@ -85,6 +85,7 @@ export const getTags = (indexPattern: DataViewListItem | DataView, isDefault: bo
   return tags;
 };
 
+// todo add to this
 export const areScriptedFieldsEnabled = (indexPattern: DataViewListItem | DataView) => {
   return !isRollup(indexPattern.type);
 };

src/plugins/data_views/common/data_views/data_views.test.ts

@@ -115,6 +115,7 @@ describe('IndexPatterns', () => {
       onRedirectNoIndexPattern: () => {},
       getCanSave: () => Promise.resolve(true),
       getCanSaveAdvancedSettings: () => Promise.resolve(true),
+      scriptedFieldsEnabled: true,
     });
 
     indexPatternsNoAccess = new DataViewsService({
@@ -127,6 +128,7 @@ describe('IndexPatterns', () => {
       onRedirectNoIndexPattern: () => {},
       getCanSave: () => Promise.resolve(false),
       getCanSaveAdvancedSettings: () => Promise.resolve(false),
+      scriptedFieldsEnabled: true,
     });
   });
 

src/plugins/data_views/common/data_views/data_views.ts

@@ -120,6 +120,8 @@ export interface DataViewsServiceDeps {
    * Determines whether the user can save advancedSettings (used for defaultIndex)
    */
   getCanSaveAdvancedSettings: () => Promise<boolean>;
+
+  scriptedFieldsEnabled: boolean;
 }
 
 /**
@@ -325,6 +327,8 @@ export class DataViewsService {
    * Can the user save data views?
    */
   public getCanSave: () => Promise<boolean>;
+
+  public readonly scriptedFieldsEnabled: boolean;
   /**
    * DataViewsService constructor
    * @param deps Service dependencies
@@ -339,6 +343,7 @@ export class DataViewsService {
       onError,
       getCanSave = () => Promise.resolve(false),
       getCanSaveAdvancedSettings,
+      scriptedFieldsEnabled,
     } = deps;
     this.apiClient = apiClient;
     this.config = uiSettings;
@@ -350,6 +355,7 @@ export class DataViewsService {
     this.getCanSaveAdvancedSettings = getCanSaveAdvancedSettings;
 
     this.dataViewCache = createDataViewCache();
+    this.scriptedFieldsEnabled = scriptedFieldsEnabled;
   }
 
   /**
@@ -591,7 +597,9 @@ export class DataViewsService {
   private refreshFieldsFn = async (indexPattern: DataView) => {
     const { fields, indices } = await this.getFieldsAndIndicesForDataView(indexPattern);
     fields.forEach((field) => (field.isMapped = true));
-    const scripted = indexPattern.getScriptedFields().map((field) => field.spec);
+    const scripted = this.scriptedFieldsEnabled
+      ? indexPattern.getScriptedFields().map((field) => field.spec)
+      : [];
     const fieldAttrs = indexPattern.getFieldAttrs();
     const fieldsWithSavedAttrs = Object.values(
       this.fieldArrayToMap([...fields, ...scripted], fieldAttrs)
@@ -655,7 +663,9 @@ export class DataViewsService {
     displayErrors: boolean = true
   ) => {
     const fieldsAsArr = Object.values(fields);
-    const scriptedFields = fieldsAsArr.filter((field) => field.scripted);
+    const scriptedFields = this.scriptedFieldsEnabled
+      ? fieldsAsArr.filter((field) => field.scripted)
+      : [];
     try {
       let updatedFieldList: FieldSpec[];
       const { fields: newFields, indices } = await this.getFieldsAndIndicesForWildcard(options);

src/plugins/data_views/public/data_views_service_public.ts

@@ -29,6 +29,7 @@ export interface DataViewsServicePublicDeps extends DataViewsServiceDeps {
     showAllIndices?: boolean;
     isRollupIndex: (indexName: string) => boolean;
   }) => Promise<MatchedItem[]>;
+  scriptedFieldsEnabled: boolean;
 }
 
 /**
@@ -44,6 +45,7 @@ export class DataViewsServicePublic extends DataViewsService {
     isRollupIndex: (indexName: string) => boolean;
   }) => Promise<MatchedItem[]>;
   public hasData: HasDataService;
+  public readonly scriptedFieldsEnabled: boolean;
 
   /**
    * Constructor
@@ -55,5 +57,6 @@ export class DataViewsServicePublic extends DataViewsService {
     this.getCanSaveSync = deps.getCanSaveSync;
     this.hasData = deps.hasData;
     this.getIndices = deps.getIndices;
+    this.scriptedFieldsEnabled = deps.scriptedFieldsEnabled;
   }
 }

src/plugins/data_views/public/index.ts

@@ -6,6 +6,8 @@
  * Side Public License, v 1.
  */
 
+import { PluginInitializerContext } from '@kbn/core/public';
+
 export {
   ILLEGAL_CHARACTERS_KEY,
   CONTAINS_SPACES_KEY,
@@ -55,8 +57,8 @@ export { UiSettingsPublicToCommon } from './ui_settings_wrapper';
 
 import { DataViewsPublicPlugin } from './plugin';
 
-export function plugin() {
-  return new DataViewsPublicPlugin();
+export function plugin(initializerContext: PluginInitializerContext) {
+  return new DataViewsPublicPlugin(initializerContext);
 }
 
 export type {

src/plugins/data_views/public/plugin.ts

@@ -6,7 +6,7 @@
  * Side Public License, v 1.
  */
 
-import { CoreSetup, CoreStart, Plugin } from '@kbn/core/public';
+import { CoreSetup, CoreStart, Plugin, PluginInitializerContext } from '@kbn/core/public';
 import { i18n } from '@kbn/i18n';
 import { getIndexPatternLoad } from './expressions';
 import {
@@ -16,6 +16,10 @@ import {
   DataViewsPublicStartDependencies,
 } from './types';
 
+interface ClientConfigType {
+  scriptedFieldsEnabled?: boolean;
+}
+
 import { DataViewsApiClient } from '.';
 import { ContentMagementWrapper } from './content_management_wrapper';
 
@@ -40,6 +44,8 @@ export class DataViewsPublicPlugin
 {
   private readonly hasData = new HasData();
 
+  constructor(private readonly initializerContext: PluginInitializerContext) {}
+
   public setup(
     core: CoreSetup<DataViewsPublicStartDependencies, DataViewsPublicPluginStart>,
     { expressions, contentManagement }: DataViewsPublicSetupDependencies
@@ -74,6 +80,8 @@ export class DataViewsPublicPlugin
       10000
     );
 
+    const config = this.initializerContext.config.get<ClientConfigType>();
+
     return new DataViewsServicePublic({
       hasData: this.hasData.start(core),
       uiSettings: new UiSettingsPublicToCommon(uiSettings),
@@ -91,6 +99,7 @@ export class DataViewsPublicPlugin
       getCanSaveAdvancedSettings: () =>
         Promise.resolve(application.capabilities.advancedSettings.save === true),
       getIndices: (props) => getIndices({ ...props, http: core.http }),
+      scriptedFieldsEnabled: config.scriptedFieldsEnabled === false ? false : true, // accounting for null value
     });
   }
 

src/plugins/data_views/public/types.ts

@@ -120,6 +120,7 @@ export interface DataViewsServicePublic extends DataViewsServicePublicMethods {
     showAllIndices?: boolean;
     isRollupIndex: (indexName: string) => boolean;
   }) => Promise<MatchedItem[]>;
+  scriptedFieldsEnabled: boolean;
 }
 
 export type DataViewsContract = DataViewsServicePublic;

src/plugins/data_views/server/data_views_service_factory.ts

@@ -25,6 +25,7 @@ interface DataViewsServiceFactoryDeps {
   uiSettings: UiSettingsServiceStart;
   fieldFormats: FieldFormatsStart;
   capabilities: CoreStart['capabilities'];
+  scriptedFieldsEnabled: boolean;
   rollupsEnabled: boolean;
 }
 
@@ -70,5 +71,6 @@ export const dataViewsServiceFactory = (deps: DataViewsServiceFactoryDeps) =>
           : request
           ? (await capabilities.resolveCapabilities(request)).advancedSettings.save === true
           : false,
+      scriptedFieldsEnabled: deps.scriptedFieldsEnabled,
     });
   };

src/plugins/data_views/server/index.ts

@@ -6,6 +6,8 @@
  * Side Public License, v 1.
  */
 
+import { schema, TypeOf } from '@kbn/config-schema';
+import type { PluginConfigDescriptor } from '@kbn/core/server';
 export { getFieldByName, findIndexPatternById } from './utils';
 export type { FieldDescriptor, RollupIndexCapability } from './fetcher';
 export { IndexPatternsFetcher, getCapabilitiesForRollupIndices } from './fetcher';
@@ -36,6 +38,24 @@ export type {
 };
 export { DataViewsServerPlugin as Plugin };
 
+const configSchema = schema.object({
+  scriptedFieldsEnabled: schema.conditional(
+    schema.contextRef('serverless'),
+    true,
+    schema.boolean({ defaultValue: false }),
+    schema.never()
+  ),
+});
+
+type ConfigType = TypeOf<typeof configSchema>;
+
+export const config: PluginConfigDescriptor<ConfigType> = {
+  schema: configSchema,
+  exposeToBrowser: {
+    scriptedFieldsEnabled: true,
+  },
+};
+
 export {
   SERVICE_PATH,
   SERVICE_PATH_LEGACY,

src/plugins/data_views/server/mocks.ts

@@ -12,6 +12,7 @@ export function createIndexPatternsStartMock() {
   const dataViewsServiceFactory = jest.fn().mockResolvedValue({ get: jest.fn() });
   return {
     dataViewsServiceFactory,
+    getScriptedFieldsEnabled: jest.fn().mockReturnValue(true),
   };
 }