[CCR] Migrate all usages of EuiPage*_Deprecated #163135

gitstart · 2023-08-04T01:29:57Z

What does this PR do?

Migrate all usages of EuiPage*_Deprecated in Cross cluster replication

Issue References

[CCR] Migrate all usages of EuiPage*_Deprecated #163019

Video/Screenshot Demo

x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/follower_indices_list.js

x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/auto_follow_pattern_list.js

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>

kibanamachine · 2023-08-04T01:29:59Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

alisonelizabeth · 2023-08-07T19:24:41Z

Hi @gitstart! Thank you for your contribution ❤️

Can you please provide screenshots of the changes you have made? This will help us greatly with the review and confirm the changes have been tested.

Also - a quick note: While the “How” section in #161413 provides a quick conversion map, unfortunately, this does not work for all cases. Please refer to the EUI guidelines on how to approach the migration and examples. You can also take a look at this PR as a reference implementation: #163134.

Please let us know if you have any questions. Thanks!

…thub.com/gitstart/kibana into ELS-172

Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>

…thub.com/gitstart/kibana into ELS-172

Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>

elasticmachine · 2023-08-17T13:36:30Z

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

yuliacech · 2023-08-17T13:37:14Z

buildkite test this

yuliacech · 2023-08-17T15:14:32Z

x-pack/plugins/cross_cluster_replication/public/app/app.tsx

+            id="xpack.crossClusterReplication.app.permissionCheckTitle"
+            defaultMessage="Checking permissions…"
+          />
+        </SectionLoading>


Verified ✅

yuliacech · 2023-08-17T15:16:46Z

x-pack/plugins/cross_cluster_replication/public/app/app.tsx

+              />
+            </p>
+          }
+        />


Verified ✅

yuliacech · 2023-08-17T15:18:21Z

...s_cluster_replication/public/app/sections/auto_follow_pattern_add/auto_follow_pattern_add.js

+                  id="xpack.crossClusterReplication.autoFollowPatternCreateForm.loadingRemoteClustersMessage"
+                  defaultMessage="Loading remote clusters…"
+                />
+              </SectionLoading>


Verified ✅

yuliacech · 2023-08-17T15:22:05Z

...s_cluster_replication/public/app/sections/auto_follow_pattern_add/auto_follow_pattern_add.js

            );
          }

          return (
-            <EuiPageContentBody restrictWidth style={{ width: '100%' }}>
+            <EuiPageSection restrictWidth style={{ width: '100%' }}>


Verified ✅

yuliacech · 2023-08-17T15:28:38Z

...cluster_replication/public/app/sections/auto_follow_pattern_edit/auto_follow_pattern_edit.js

@@ -171,7 +161,7 @@ export class AutoFollowPatternEdit extends PureComponent {
          }

          return (
-            <EuiPageContentBody restrictWidth style={{ width: '100%' }}>
+            <EuiPageSection restrictWidth style={{ width: '100%' }}>


Verified ✅

yuliacech · 2023-08-17T15:29:54Z

...cluster_replication/public/app/sections/auto_follow_pattern_edit/auto_follow_pattern_edit.js

-        <SectionLoading>{loadingTitle}</SectionLoading>
-      </EuiPageContent>
-    );
+    return <SectionLoading>{loadingTitle}</SectionLoading>;


Verified ✅

yuliacech · 2023-08-17T15:42:21Z

...cluster_replication/public/app/sections/auto_follow_pattern_edit/auto_follow_pattern_edit.js

+            />
+          </EuiButton>
+        }
+      />


Verified ✅

yuliacech · 2023-08-17T15:43:42Z

...ugins/cross_cluster_replication/public/app/sections/follower_index_add/follower_index_add.js

+                  id="xpack.crossClusterReplication.followerIndexCreateForm.loadingRemoteClustersMessage"
+                  defaultMessage="Loading remote clusters…"
+                />
+              </SectionLoading>


Verified ✅

yuliacech · 2023-08-17T15:45:05Z

...ugins/cross_cluster_replication/public/app/sections/follower_index_add/follower_index_add.js

            );
          }

          return (
-            <EuiPageContentBody restrictWidth style={{ width: '100%' }}>
+            <EuiPageSection restrictWidth style={{ width: '100%' }}>


Verified ✅

yuliacech · 2023-08-17T15:45:45Z

...ins/cross_cluster_replication/public/app/sections/follower_index_edit/follower_index_edit.js

-        <SectionLoading>{loadingTitle}</SectionLoading>
-      </EuiPageContent>
-    );
+    return <SectionLoading>{loadingTitle}</SectionLoading>;


Verified ✅

yuliacech · 2023-08-17T15:47:43Z

...ins/cross_cluster_replication/public/app/sections/follower_index_edit/follower_index_edit.js

+            />
+          </EuiButton>
+        }
+      />


Verified ✅

yuliacech · 2023-08-17T15:49:23Z

...ins/cross_cluster_replication/public/app/sections/follower_index_edit/follower_index_edit.js

@@ -257,7 +246,7 @@ export class FollowerIndexEdit extends PureComponent {
          }

          return (
-            <EuiPageContentBody restrictWidth style={{ width: '100%' }}>
+            <EuiPageSection restrictWidth style={{ width: '100%' }}>


Verified ✅

yuliacech · 2023-08-17T15:51:06Z

..._cluster_replication/public/app/sections/home/follower_indices_list/follower_indices_list.js

-          }
-        />
-      </EuiPageContent>
+      <EuiPageTemplate.EmptyPrompt


Verified ✅

yuliacech · 2023-08-17T15:51:29Z

...er_replication/public/app/sections/home/auto_follow_pattern_list/auto_follow_pattern_list.js

-          }
-        />
-      </EuiPageContent>
+      <EuiPageTemplate.EmptyPrompt


Verified ✅

yuliacech

Thanks a lot for addressing the feedback, @gitstart!
The changes LGTM, verified locally that there are no regressions in UI.
I updated 2 jest tests that were failing because data-test-subj changed in the migration.

yuliacech · 2023-08-17T16:14:16Z

buildkite test this

kibana-ci · 2023-08-17T17:10:31Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 01e65e2

Failed CI Steps

Serverless Security Investigations Cypress Tests #1

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`crossClusterReplication`	168.9KB	167.7KB	-1.2KB

History

💔 Build #151418 failed 4fac824

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth · 2023-08-17T17:24:30Z

@elasticmachine run elasticsearch-ci/docs

[CCR] Migrate all usages of EuiPage*_Deprecated

c9f528b

Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>

gitstart changed the title ~~ELS-172 - [CCR] Migrate all usages of EuiPage*_Deprecated~~ [CCR] Migrate all usages of EuiPage*_Deprecated Aug 4, 2023

gitstart marked this pull request as ready for review August 4, 2023 01:38

gitstart requested a review from a team as a code owner August 4, 2023 01:38

kibanamachine added the 💝community label Aug 4, 2023

gitstart and others added 4 commits August 16, 2023 07:54

Merge commit 'ad5c9d805a0c5e2ce6f71733d159f60926a82349' of https://gi…

2c6c7d2

…thub.com/gitstart/kibana into ELS-172

[CCR] Migrate all usages of EuiPage*_Deprecated

104e5f6

Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>

Merge commit '15b118c724d174d1482ae9a31f9e87dccfe2a66c' of https://gi…

9d72c7f

…thub.com/gitstart/kibana into ELS-172

[CCR] Migrate all usages of EuiPage*_Deprecated

4fac824

Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>

yuliacech self-requested a review August 17, 2023 13:36

yuliacech added Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Aug 17, 2023

yuliacech added the release_note:skip Skip the PR/issue when compiling release notes label Aug 17, 2023

yuliacech reviewed Aug 17, 2023

View reviewed changes

x-pack/plugins/cross_cluster_replication/public/app/app.tsx

/>

</p>

}

/>

Copy link

Contributor

yuliacech Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified ✅

yuliacech reviewed Aug 17, 2023

View reviewed changes

[CCR] Fix unit tests

01e65e2

yuliacech approved these changes Aug 17, 2023

View reviewed changes

alisonelizabeth merged commit 1ab6a4c into elastic:main Aug 17, 2023

alisonelizabeth mentioned this pull request Aug 17, 2023

[CCR] Migrate all usages of EuiPage*_Deprecated #163019

Closed

kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CCR] Migrate all usages of EuiPage*_Deprecated #163135

[CCR] Migrate all usages of EuiPage*_Deprecated #163135

gitstart commented Aug 4, 2023 •

edited

Loading

kibanamachine commented Aug 4, 2023

alisonelizabeth commented Aug 7, 2023

elasticmachine commented Aug 17, 2023

yuliacech commented Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023 •

edited

Loading

yuliacech Aug 17, 2023 •

edited

Loading

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech Aug 17, 2023

yuliacech left a comment

yuliacech commented Aug 17, 2023

kibana-ci commented Aug 17, 2023

alisonelizabeth commented Aug 17, 2023

[CCR] Migrate all usages of EuiPage*_Deprecated #163135

[CCR] Migrate all usages of EuiPage*_Deprecated #163135

Conversation

gitstart commented Aug 4, 2023 • edited Loading

What does this PR do?

Issue References

Video/Screenshot Demo

kibanamachine commented Aug 4, 2023

alisonelizabeth commented Aug 7, 2023

elasticmachine commented Aug 17, 2023

yuliacech commented Aug 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuliacech Aug 17, 2023 • edited Loading

Choose a reason for hiding this comment

yuliacech Aug 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuliacech left a comment

Choose a reason for hiding this comment

yuliacech commented Aug 17, 2023

kibana-ci commented Aug 17, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

History

alisonelizabeth commented Aug 17, 2023

gitstart commented Aug 4, 2023 •

edited

Loading

yuliacech Aug 17, 2023 •

edited

Loading

yuliacech Aug 17, 2023 •

edited

Loading