Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Migrate all usages of EuiPage*_Deprecated #163132

Merged
merged 11 commits into from
Aug 22, 2023
Merged

[ILM] Migrate all usages of EuiPage*_Deprecated #163132

merged 11 commits into from
Aug 22, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Aug 4, 2023 •
edited
Loading

What does this PR do?

  • Migrate all usages of EuiPage*_Deprecated in Index Lifecycle Management

Issue References

Video/Screenshot Demo

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.container.tsx
Screenshot 2023-08-16 at 08 17 59
Screenshot 2023-08-16 at 08 19 52

x-pack/plugins/index_lifecycle_management/public/application/sections/policy_list/policy_list.container.tsx
Screenshot 2023-08-16 at 08 22 29
Screenshot 2023-08-16 at 08 23 38

x-pack/plugins/index_lifecycle_management/public/application/sections/policy_list/policy_list.tsx
Screenshot 2023-08-16 at 08 24 57

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart @LuisChiej
[ILM] Migrate all usages of EuiPage*_Deprecated
8b7cb17 
Co-authored-by: LuisChiej <[email protected]>
Co-authored-by: gitstart_bot <[email protected]>
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@gitstart gitstart changed the title ELS-168 - [ILM] Migrate all usages of EuiPage*_Deprecated [ILM] Migrate all usages of EuiPage*_Deprecated Aug 4, 2023
@gitstart gitstart marked this pull request as ready for review August 4, 2023 00:27
@gitstart gitstart requested a review from a team as a code owner August 4, 2023 00:27
@alisonelizabeth
Copy link
Contributor

Hi @gitstart! Thank you for your contribution ❤️

Can you please provide screenshots of the changes you have made? This will help us greatly with the review and confirm the changes have been tested.

Also - a quick note: While the “How” section in #161413 provides a quick conversion map, unfortunately, this does not work for all cases. Please refer to the EUI guidelines on how to approach the migration and examples. You can also take a look at this PR as a reference implementation: #163134.

Please let us know if you have any questions. Thanks!

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth added release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Aug 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

alisonelizabeth
alisonelizabeth requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @gitstart! There is a small change needed to 2 of the error states before we can merge. Please let me know if you have any questions.

...index_lifecycle_management/public/application/sections/edit_policy/edit_policy.container.tsx Show resolved Hide resolved
...index_lifecycle_management/public/application/sections/policy_list/policy_list.container.tsx Show resolved Hide resolved
@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 158.5KB 158.0KB -478.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback @gitstart! I patched up a jest test snapshot in 38b9718. Code LGTM and CI is green now 🎉

@alisonelizabeth alisonelizabeth merged commit 5eeb3f7 into elastic:main Aug 22, 2023
@alisonelizabeth alisonelizabeth mentioned this pull request Aug 22, 2023
Closed
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gitstart @kibanamachine @alisonelizabeth @elasticmachine @kibana-ci