[Upgrade Assistant] Migrate all usages of EuiPage*_Deprecated

[gitstart]

What does this PR do?

• Migrate all usages of EuiPage*_Deprecated in Upgrade Assistant

Issue References

Fixes #163071

Video/Screenshot Demo

Path

x-pack/plugins/upgrade_assistant/public/application/components/es_deprecation_logs/es_deprecation_logs.tsx

Path:

x-pack/plugins/upgrade_assistant/public/application/app.tsx

Not authorized:

Authorized:

Is cluster upgrading:

Cluster is upgraded:

---

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[alisonelizabeth]

Hi @gitstart! Thank you for your contribution ❤️

Can you please provide screenshots of the changes you have made? This will help us greatly with the review and confirm the changes have been tested.

Also - a quick note: While the “How” section in #161413 provides a quick conversion map, unfortunately, this does not work for all cases. Please refer to the EUI guidelines on how to approach the migration and examples. You can also take a look at this PR as a reference implementation: #163134.

Please let us know if you have any questions. Thanks!

[gitstart]

Hi @gitstart! Thank you for your contribution ❤️

Can you please provide screenshots of the changes you have made? This will help us greatly with the review and confirm the changes have been tested.

Also - a quick note: While the “How” section in #161413 provides a quick conversion map, unfortunately, this does not work for all cases. Please refer to the EUI guidelines on how to approach the migration and examples. You can also take a look at this PR as a reference implementation: #163134.

Please let us know if you have any questions. Thanks!

Yes, a quick question. How can we run it and find exactly the visual changes made

[yuliacech]

Yes, a quick question. How can we run it and find exactly the visual changes made

@gitstart Please refer to the dev documentation on how to run kibana locally. In short that would be the following:

1. checkout the repo git clone https://github.com/[YOUR_USERNAME]/kibana.git kibana
2. install the correct node version nvm use
3. install dependencies yarn kbn bootstrap
4. start Elasticsearch in one terminal yarn es snapshot
5. start Kibana in another terminal yarn start

[gitstart]

Yes, a quick question. How can we run it and find exactly the visual changes made

@gitstart Please refer to the dev documentation on how to run kibana locally. In short that would be the following:

1. checkout the repo git clone https://github.com/[YOUR_USERNAME]/kibana.git kibana
2. install the correct node version nvm use
3. install dependencies yarn kbn bootstrap
4. start Elasticsearch in one terminal yarn es snapshot
5. start Kibana in another terminal yarn start

Hello @yuliacech, Thank you for this. We already run this, I am though referring to how to trace the components easily to take screenshots. Thank you 😊

[gitstart]

Yes, a quick question. How can we run it and find exactly the visual changes made

@gitstart Please refer to the dev documentation on how to run kibana locally. In short that would be the following:

1. checkout the repo git clone https://github.com/[YOUR_USERNAME]/kibana.git kibana
2. install the correct node version nvm use
3. install dependencies yarn kbn bootstrap
4. start Elasticsearch in one terminal yarn es snapshot
5. start Kibana in another terminal yarn start

Hello @yuliacech, Thank you for this. We already run this, I am though referring to how to trace the components easily to take screenshots. Thank you 😊

@alisonelizabeth

[alisonelizabeth]

Hello @yuliacech, Thank you for this. We already run this, I am though referring to how to trace the components easily to take screenshots. Thank you 😊

You can view Upgrade Assistant at /app/management/stack/upgrade_assistant/overview. You can also check out the plugin's readme for more details.

[elasticmachine]

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

[alisonelizabeth]

@elasticmachine merge upstream

[alisonelizabeth]

Thanks for your contribution @gitstart! I'd like to see one more change made in deprecations_page_loading_error.tsx, otherwise code looks good.

[alisonelizabeth]

buildkite test this

[alisonelizabeth]

@gitstart please also review the CI failures in #163127 (comment)

[alisonelizabeth]

Hi @gitstart - we're getting close. It looks like some of the data-test-subj data attributes were lost in the changes, which is causing tests to fail. I tried to identify the places that need to be addressed in the code. Please have a look. You can see more information about the test failures in #163127 (comment).

[alisonelizabeth]

We should preserve the same top-level data-test-subj so no changes are required in the test

Suggested change

	data-test-subj="emptyPrompt"
	data-test-subj="isUpgradeCompleteMessage"

[alisonelizabeth]

We should preserve the same top-level data-test-subj so no changes are required in the test

Suggested change

	data-test-subj="emptyPrompt"
	data-test-subj="isUpgradingMessage"

[alisonelizabeth]

We need to retain this data-test-subj for tests

[alisonelizabeth]

@elasticmachine merge upstream

[alisonelizabeth]

buildkite test this

[alisonelizabeth]

@elasticmachine run elasticsearch-ci/docs

[alisonelizabeth]

@elasticmachine merge upstream

[alisonelizabeth]

@elasticmachine run elasticsearch-ci/docs

[alisonelizabeth]

buildkite test this

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 1f1e1f3

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
upgradeAssistant	156.2KB	155.1KB	-1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
esUiShared	156.4KB	156.5KB	+58.0B

History

• 💔 Build #152006 failed bc7888b
• 💔 Build #151172 failed 4e3723e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[alisonelizabeth]

Thanks for addressing my feedback @gitstart! I pushed up a small change via e257e68. I left the dataTestSubj prop support, but I think it's best to address the EUI migration as part of #163018. CI is green and latest LGTM 🎉