Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[share] hide 'Embed code' share option when buildFlavor is 'serverless' #163104

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 3, 2023

Closes #161266

Overview

PR hides 'Embed code' share option in serverless

Test

  • Start kibana with yarn start --serverless=es
  • verify 'Embed code' is not displayed in Dashboard share option

@nreese nreese changed the title hide 'Embed code' share option when buildFlavor is 'serverless' [share] hide 'Embed code' share option when buildFlavor is 'serverless' Aug 3, 2023
@nreese nreese marked this pull request as ready for review August 3, 2023 19:59
@nreese nreese requested a review from a team as a code owner August 3, 2023 19:59
@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Aug 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@nreese
Copy link
Contributor Author

nreese commented Aug 7, 2023

@elasticmachine merge upstream

@nreese nreese requested a review from sebelga August 7, 2023 16:12
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 51.8KB 51.9KB +107.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nreese

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nreese nreese merged commit 6957901 into elastic:main Aug 8, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 8, 2023
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
…s' (elastic#163104)

Closes elastic#161266

### Overview
PR hides 'Embed code' share option in serverless

### Test
* Start kibana with `yarn start --serverless=es`
* verify 'Embed code' is not displayed in Dashboard share option

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Hide embed code shortcut for serverless
5 participants