-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[share] hide 'Embed code' share option when buildFlavor is 'serverless' #163104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
changed the title
hide 'Embed code' share option when buildFlavor is 'serverless'
[share] hide 'Embed code' share option when buildFlavor is 'serverless'
Aug 3, 2023
nreese
added
release_note:skip
Skip the PR/issue when compiling release notes
v8.10.0
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
labels
Aug 3, 2023
Pinging @elastic/appex-sharedux (Team:SharedUX) |
sebelga
reviewed
Aug 4, 2023
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @nreese |
sebelga
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
…s' (elastic#163104) Closes elastic#161266 ### Overview PR hides 'Embed code' share option in serverless ### Test * Start kibana with `yarn start --serverless=es` * verify 'Embed code' is not displayed in Dashboard share option --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161266
Overview
PR hides 'Embed code' share option in serverless
Test
yarn start --serverless=es