Update Project Selection in Serverless Top Navigation #163076

Dosant · 2023-08-03T14:24:23Z

Summary

Changing My Deployments -> Projects
Removing hardcoded url and passing one from the config

@Dosant to add this setting to cloud

Dosant · 2023-08-03T14:25:42Z

config/serverless.yml

@@ -9,6 +9,7 @@ xpack.fleet.internal.activeAgentsSoftLimit: 25000

 # Cloud links
 xpack.cloud.base_url: "https://cloud.elastic.co"
+xpack.cloud.projects_url: "/projects/"


Curious what are your thoughts on this?

We will propagate the correct value from cloud, but I'd like to have something displayed locally for testing. Is it fine to keep it here? Or should I hardcode some fallback from code?

I wouldn't commit it in the repo. Good to mention it in the PR description for local testing. I removed all those URLs here https://github.com/elastic/kibana/pull/161971/files#diff-ebeb9e9dc4c3ee5e81f743f0eda3c06f1fc161a11127b374d21f0da5e6368fd9

So I am not sure about this, because developers starting it locally would not see the cloud URLs you've added in the sidenav and wouldn't see this link in the header.

@elastic/kibana-core, Curious, what would you recommend?

Seems that we need a serverless.dev.yml then

One alternative is to handle this at the config level:

projects_url: schema.conditional( schema.contextRef('serverless'), true, schema.string({ defaultValue: '/projects'}), schema.maybe(schema.string()) )

Would that be appropriate for something like this setting? This way it can always be overridden, but --serverless flag would make it default to /projects.

Seems that we need a serverless.dev.yml then

Feel like this might be a broader discussion as it would be useful for cases other than this!

We could even make schema.maybe(schema.string()) => schema.never() if this is only intended for serverless.

One alternative is to handle this at the config level:

I like this approach, we also have other URLs like this that we didn't add to config, so they are undefined locally and aren't visible. I'd personally prefer to see them even if they lead to nowhere or to a wrong env.
https://github.com/elastic/kibana/pull/161971/files#diff-ebeb9e9dc4c3ee5e81f743f0eda3c06f1fc161a11127b374d21f0da5e6368fd9

@jloleysens, I've follow you suggestion for this new config: eebd9fb

I didn't touch other existing configs

Dosant · 2023-08-03T14:27:03Z

x-pack/plugins/cloud/public/types.ts

+  /**
+   * The full URL to the serverless projects page on Elastic Cloud. Undefined if not running in Serverless.
+   */
+  projectsUrl?: string;


Not sure about this, because this could also go inside serverless.*
The problem with putting it inside serverless is that it would be tricky to test this locally as serveless.* must specify projectid

I think it is ok here. Serverless is Cloud. Now if we want to group the urls under a "serverless" parent that could be an option

interface CloudStart { serverless: { projectsUrl?: string; } ... }

there is already serverless parent config, but I am on a fence about putting it there because a valid servleless config requires projectid and the testing local config that just includes serverless.prjectsUrl would be considered invalid

…fix'

…ant/kibana into d/2023-08-03-change-deployments-link

elasticmachine · 2023-08-03T15:58:30Z

Pinging @elastic/appex-sharedux (Team:SharedUX)

…ange-deployments-link

Dosant · 2023-08-04T10:45:14Z

@elasticmachine merge upstream

sebelga

LGTM! 👍

sebelga · 2023-08-04T10:37:20Z

config/serverless.yml

@@ -9,6 +9,7 @@ xpack.fleet.internal.activeAgentsSoftLimit: 25000

 # Cloud links
 xpack.cloud.base_url: "https://cloud.elastic.co"
+xpack.cloud.projects_url: "/projects/"


I wouldn't commit it in the repo. Good to mention it in the PR description for local testing. I removed all those URLs here https://github.com/elastic/kibana/pull/161971/files#diff-ebeb9e9dc4c3ee5e81f743f0eda3c06f1fc161a11127b374d21f0da5e6368fd9

sebelga · 2023-08-04T10:40:11Z

packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx

@@ -225,6 +225,11 @@ export class ChromeService {
      projectNavigation.setProjectHome(homeHref);
    };

+    const setProjectsUrl = (projectsUrl: string) => {


I wonder if at some point replacing all the setters with a single one would make sense... Maybe not as that function would be a big one instead of many small functions... 🤔

updateProjectConfig({ ... partial configs here });

sebelga · 2023-08-04T10:46:43Z

x-pack/plugins/cloud/public/types.ts

+  /**
+   * The full URL to the serverless projects page on Elastic Cloud. Undefined if not running in Serverless.
+   */
+  projectsUrl?: string;


I think it is ok here. Serverless is Cloud. Now if we want to group the urls under a "serverless" parent that could be an option

interface CloudStart { serverless: { projectsUrl?: string; } ... }

azasypkin · 2023-08-04T14:50:31Z

x-pack/plugins/cloud/public/types.ts

+  /**
+   * The full URL to the serverless projects page on Elastic Cloud. Undefined if not running in Serverless.
+   */
+  projectsUrl?: string;


Sorry for hijacking, but will projectsUrl or at least baseUrl be exposed on the server-side contract? We need this on the server side to implement #162887

I think exposing all URLs server-side makes sense; It shouldn't be a problem as they are all static. But I think it better to do in a separate pr

I think exposing all URLs server-side makes sense; It shouldn't be a problem as they are all static. But I think it better to do in a separate pr

Thanks! Do you need a GitHub issue for that, or is it already on your radar?

@azasypkin, I am passing by this code myself 😅, I think this is for the @elastic/kibana-core team and I was just sharing my opinion on exposing the URLs. If they agree, I can help out and follow up after this pr

Roger that @Dosant! Then, forwarding my question to @elastic/kibana-core - do you folks want me to file a GitHub issue to expose these configuration flags via the server-side contract, or is it already on your radar (unless there is a reason not to expose this)? We need this for #162887 that is targeting Serverless MVP.

+1 from me to expose URL values in cloud plugin's server side. Might be good to have an issue to know which values you need, thanks!

…ange-deployments-link

jloleysens

Config changes LGTM

kibana-ci · 2023-08-07T12:37:41Z

💚 Build Succeeded

Buildkite Build
Commit: f84d6b6

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`cloud`	15	16	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cloud`	5.4KB	5.4KB	+62.0B
`core`	372.0KB	372.2KB	+233.0B
`serverless`	5.4KB	5.4KB	+60.0B
total			+355.0B

Unknown metric groups

API count

id	before	after	diff
`cloud`	65	68	+3

History

💔 Build #147831 failed 662e886
💚 Build #147462 succeeded 72be0c0
💔 Build #147452 failed dd35820
💔 Build #147202 failed 8b85a2e
💔 Build #147191 failed b8adfc0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

azasypkin

Changes in plugin_functional/test_suites/core_plugins/rendering.ts LGTM.

## Summary close elastic#163014 - Changing `My Deployments -> Projects` - Removing hardcoded url and passing one from the config

Dosant added 2 commits August 3, 2023 16:22

wip

3726abc

fix lint

1c962b0

Dosant commented Aug 3, 2023

View reviewed changes

kibanamachine and others added 4 commits August 3, 2023 14:33

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

5c349b9

…fix'

fix ts

7c28472

Merge branch 'd/2023-08-03-change-deployments-link' of github.com:Dos…

b8adfc0

…ant/kibana into d/2023-08-03-change-deployments-link

fix i18n

8b85a2e

Dosant changed the title ~~D/2023 08 03 change deployments link~~ Update Project Selection in Serverless Top Navigation Aug 3, 2023

Dosant marked this pull request as ready for review August 3, 2023 15:58

Dosant requested review from a team as code owners August 3, 2023 15:58

Dosant requested a review from sebelga August 3, 2023 15:58

Dosant added 2 commits August 4, 2023 11:51

fix core test

f8c59e9

Merge branch 'main' of github.com:elastic/kibana into d/2023-08-03-ch…

dd35820

…ange-deployments-link

Dosant requested a review from a team as a code owner August 4, 2023 09:52

Merge branch 'main' into d/2023-08-03-change-deployments-link

72be0c0

sebelga approved these changes Aug 4, 2023

View reviewed changes

azasypkin reviewed Aug 4, 2023

View reviewed changes

Dosant added 3 commits August 7, 2023 11:11

Merge branch 'main' of github.com:elastic/kibana into d/2023-08-03-ch…

bd6e7e1

…ange-deployments-link

allow “projects_url” only in serverless, set default in the config

eebd9fb

consistency

662e886

Dosant requested a review from jloleysens August 7, 2023 09:51

fix

f84d6b6

jloleysens approved these changes Aug 7, 2023

View reviewed changes

Dosant requested a review from azasypkin August 7, 2023 13:34

azasypkin reviewed Aug 7, 2023

View reviewed changes

azasypkin approved these changes Aug 7, 2023

View reviewed changes

Dosant merged commit 1047eef into elastic:main Aug 7, 2023

kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 7, 2023

Dosant self-assigned this Aug 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Project Selection in Serverless Top Navigation #163076

Update Project Selection in Serverless Top Navigation #163076

Dosant commented Aug 3, 2023 •

edited

Loading

Dosant Aug 3, 2023

sebelga Aug 4, 2023

Dosant Aug 4, 2023

sebelga Aug 4, 2023

jloleysens Aug 4, 2023

jloleysens Aug 4, 2023

Dosant Aug 4, 2023

Dosant Aug 7, 2023

Dosant Aug 3, 2023

sebelga Aug 4, 2023

Dosant Aug 4, 2023

elasticmachine commented Aug 3, 2023

Dosant commented Aug 4, 2023

sebelga left a comment

sebelga Aug 4, 2023

sebelga Aug 4, 2023

sebelga Aug 4, 2023

azasypkin Aug 4, 2023

Dosant Aug 7, 2023

azasypkin Aug 7, 2023

Dosant Aug 7, 2023

azasypkin Aug 7, 2023

jloleysens Aug 8, 2023 •

edited

Loading

jloleysens left a comment

kibana-ci commented Aug 7, 2023

API count

azasypkin left a comment

Update Project Selection in Serverless Top Navigation #163076

Update Project Selection in Serverless Top Navigation #163076

Conversation

Dosant commented Aug 3, 2023 • edited Loading

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Aug 3, 2023

Dosant commented Aug 4, 2023

sebelga left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jloleysens Aug 8, 2023 • edited Loading

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

kibana-ci commented Aug 7, 2023

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Page load bundle

API count

History

azasypkin left a comment

Choose a reason for hiding this comment

Dosant commented Aug 3, 2023 •

edited

Loading

jloleysens Aug 8, 2023 •

edited

Loading