Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Move risk score API schemas to /common/api #163032

Merged
merged 4 commits into from
Aug 7, 2023
Merged

[Security Solution] Move risk score API schemas to /common/api #163032

merged 4 commits into from
Aug 7, 2023

Conversation

marshallmain
Copy link
Contributor

@marshallmain marshallmain added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Aug 3, 2023
@marshallmain marshallmain marked this pull request as ready for review August 3, 2023 14:17
@marshallmain marshallmain requested a review from a team as a code owner August 3, 2023 14:17
@marshallmain marshallmain added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Aug 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

rylnd
rylnd reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here LGTM, but while we technically own this @elastic/security-threat-hunting-explore wrote this originally and I don't think we've touched it since. Might be worth soliciting a quick review from them 👍.

P.S. Are you going to split /common/api up in CODEOWNERS?

@rylnd rylnd requested a review from a team August 3, 2023 17:33
@marshallmain
Copy link
Contributor Author

Are you going to split /common/api up in CODEOWNERS?

Yeah good point, just updated CODEOWNERS for /common/api/risk_score on this PR branch. The other /common/api domains each have an owner assigned except for search_strategy right now, which we'll need to add.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@marshallmain marshallmain merged commit 30ca22c into elastic:main Aug 7, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 7, 2023
@marshallmain marshallmain deleted the move-risk-score-schemas branch August 7, 2023 14:33
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
@marshallmain @bryce-b
[Security Solution] Move risk score API schemas to /common/api (elast…
7df8c13 
…ic#163032)

Closes elastic/security-team#7101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd left review comments

@angorayc angorayc angorayc approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marshallmain @elasticmachine @kibana-ci @rylnd @angorayc @kibanamachine