Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: rolling file appender #162851

Merged

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jul 31, 2023

fix #108633

Unskip test to see if it's still failing in latest versions

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Risk Probability Severity Mitigation/Notes
The test becomes flaky again unknown unknown Integration tests will verify that the rolling file logging appended correctly rolls files when using the 'size-limit' policy with 'numeric' strategy

@TinaHeiligers TinaHeiligers added Feature:Logging v8.10.0 v8.9.1 Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes labels Jul 31, 2023
@TinaHeiligers
Copy link
Contributor Author

Failiure not related to logging test failing.
Merging in main and retrying

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers marked this pull request as ready for review August 1, 2023 21:07
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner August 1, 2023 21:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers
Copy link
Contributor Author

The same test failing in main as in #162854. We can't run these in the flaky test runner. The best we can do is wait and see if the test fails again in our latest branches.
cc @elastic/kibana-operations

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit b443c0c into elastic:main Aug 3, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 3, 2023
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Ahmad Bamieh <[email protected]>
(cherry picked from commit b443c0c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 3, 2023
# Backport

This will backport the following commits from `main` to `8.9`:
- [Flaky test: rolling file appender
(#162851)](#162851)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christiane (Tina)
Heiligers","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-03T20:46:14Z","message":"Flaky
test: rolling file appender (#162851)\n\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Ahmad Bamieh
<[email protected]>","sha":"b443c0cb9dfd6e34850b2403c8a45f655130e03d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Logging","v8.10.0","v8.9.1"],"number":162851,"url":"https://github.com/elastic/kibana/pull/162851","mergeCommit":{"message":"Flaky
test: rolling file appender (#162851)\n\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Ahmad Bamieh
<[email protected]>","sha":"b443c0cb9dfd6e34850b2403c8a45f655130e03d"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162851","number":162851,"mergeCommit":{"message":"Flaky
test: rolling file appender (#162851)\n\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Ahmad Bamieh
<[email protected]>","sha":"b443c0cb9dfd6e34850b2403c8a45f655130e03d"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logging release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.9.1 v8.10.0
Projects
None yet
5 participants