Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust cypress jobs config #162729

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Adjust cypress jobs config #162729

merged 8 commits into from
Jul 31, 2023

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jul 28, 2023

Summary

Adjust cypress buildkite job configs

retry:
automatic:
- exit_status: '-1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do exit_statuss -1 and * indicate? What is the effect of these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer:

-1 means buildkite agent connection was aborted. docs

The effect here will be that we only retry these jobs once (instead of thrice) in the case of timeout (or of failure).

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #1 / Alert details expandable flyout right panel overview tab insights section should display threat intelligence section should display threat intelligence section

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski marked this pull request as ready for review July 29, 2023 14:42
@patrykkopycinski patrykkopycinski requested review from a team as code owners July 29, 2023 14:42
@patrykkopycinski patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Jul 29, 2023
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 is received when an agent is lost. The retries adjusted here are meant for spot instance early termination. In practice I don't think I've seen more than 1 retry needed, but making a note in case something comes up.

@patrykkopycinski patrykkopycinski merged commit 02a43a1 into main Jul 31, 2023
@patrykkopycinski patrykkopycinski deleted the chore/adjust-cypress-config branch July 31, 2023 13:42
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 31, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
## Summary

Adjust cypress buildkite job configs

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:all-cypress-suites release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants