-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Add range query to terms enum call #162614
[APM] Add range query to terms enum call #162614
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/apm-ui (Team:APM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM, there is already an api test. Could you please update it to cover the time ranges
I already did update it to have time range ? Did you meant something else ? Do you mean to add more expectation based on time range ? If yes, i did not add it intentionally as the index filter addition should not change the expectation, but improve performance. Let me know if you have any other idea |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Oh my bad, I totally missed your last commit. All good, thanks for updating the tests as well |
Closes #159202