-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Unskip Data frame analytics feature importance tests #162601
Conversation
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @qn895 |
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
) (#162650) # Backport This will backport the following commits from `main` to `8.9`: - [[ML] Unskip Data frame analytics feature importance tests (#162601)](#162601) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Quynh Nguyen (Quinn)","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-27T15:52:54Z","message":"[ML] Unskip Data frame analytics feature importance tests (#162601)","sha":"a3c0914dae4eb447aa6be235fff3b2fde9725400","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:Data Frame Analytics","v8.10.0","v8.9.1"],"number":162601,"url":"https://github.com/elastic/kibana/pull/162601","mergeCommit":{"message":"[ML] Unskip Data frame analytics feature importance tests (#162601)","sha":"a3c0914dae4eb447aa6be235fff3b2fde9725400"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162601","number":162601,"mergeCommit":{"message":"[ML] Unskip Data frame analytics feature importance tests (#162601)","sha":"a3c0914dae4eb447aa6be235fff3b2fde9725400"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Quynh Nguyen (Quinn) <[email protected]>
Summary
This PR unskips failed tests from #162427, which should now be fixed thanks to elastic/elasticsearch#97970.
It also make it so that if
topClasses
is somehow undefined or unavailable in the future. It would not cause the page to go blank. The tests should still fail in that case because it should still expect the chart to exist.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers