Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content management mSearch to viz, lens, and event annotation group #162450

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jul 25, 2023

Summary

Adds content management api mSearch functionality to lens, visualization, and event_annotation_group types via abstracted function and types.

Part of #161545

@mattkime mattkime self-assigned this Jul 25, 2023
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you could update the example and test/examples/content_management/msearch.ts to include the newly added types?

allowedSavedObjectAttributes: string[];
}

function savedObjectToItem<Attributes extends object>(
Copy link
Contributor

@Dosant Dosant Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to understand better, is this function always applicable for any saved object, or is there a scenario where it will have to be changed for a specific saved object type later (maybe with some data changes)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, I had run into a case where a malformed saved object could throw validation errors since all SO attributes were being added to the resulting object. Therefore I decided it was best to treat the SO doc itself like an api that needs to specify its inputs.

@Dosant
Copy link
Contributor

Dosant commented Jul 25, 2023

@elasticmachine merge upstream

@mattkime mattkime marked this pull request as ready for review July 25, 2023 14:19
@mattkime mattkime requested review from a team as code owners July 25, 2023 14:19
@mattkime mattkime added Feature:Lens Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jul 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Jul 25, 2023
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visualizations team changes LGTM! Everything works as expected

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 👍

@mattkime mattkime enabled auto-merge (squash) July 26, 2023 12:35
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/content-management-utils 115 122 +7
Unknown metric groups

API count

id before after diff
@kbn/content-management-utils 180 187 +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@mattkime mattkime merged commit 0f88961 into elastic:main Jul 26, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 26, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
…up (elastic#162450)

## Summary

Adds content management api mSearch functionality to `lens`,
`visualization`, and `event_annotation_group` types via abstracted
function and types.

Part of elastic#161545

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants