-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content management mSearch to viz, lens, and event annotation group #162450
Add content management mSearch to viz, lens, and event annotation group #162450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think you could update the example and test/examples/content_management/msearch.ts
to include the newly added types?
allowedSavedObjectAttributes: string[]; | ||
} | ||
|
||
function savedObjectToItem<Attributes extends object>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to understand better, is this function always applicable for any saved object, or is there a scenario where it will have to be changed for a specific saved object type later (maybe with some data changes)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, I had run into a case where a malformed saved object could throw validation errors since all SO attributes were being added to the resulting object. Therefore I decided it was best to treat the SO doc itself like an api that needs to specify its inputs.
@elasticmachine merge upstream |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visualizations team changes LGTM! Everything works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Discovery changes LGTM 👍
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: cc @mattkime |
…up (elastic#162450) ## Summary Adds content management api mSearch functionality to `lens`, `visualization`, and `event_annotation_group` types via abstracted function and types. Part of elastic#161545 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
Summary
Adds content management api mSearch functionality to
lens
,visualization
, andevent_annotation_group
types via abstracted function and types.Part of #161545