Add feature flag for new Threshold Alert details page

[benakansara]

Resolves #162393

Adds a new feature flag xpack.observability.unsafe.alertDetails.observability.enabled to show/hide threshold alert details page until it is ready for GA.

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a8c5fcb
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observability	1.1MB	1.1MB	+48.0B

History

• 💔 Build #144240 failed 01a9881

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

[elasticmachine]

Pinging @elastic/actionable-observability (Team: Actionable Observability)

[kc13greiner]

LGTM!

[maryam-saeidi]

LGTM! Not sure how to test it locally :D

[benakansara]

Not sure how to test it locally

@maryam-saeidi To test, you can add xpack.observability.unsafe.alertDetails.observability.enabled: true in kibana.dev.yml file. Then when you click on alert reason or "Alert details" link, it should redirect to alert details page instead of opening alert flyout.

[maryam-saeidi]

@benakansara Interesting, I didn't see any usage of this flag in this PR, so I assumed it would be used later. I tested it locally, and it worked as expected 👍🏻

Where in the code are we using this flag?

[benakansara]

The logic to check feature flag was already there. If we follow the pattern of feature flags of other alert details pages, we only need to add the feature flag (checking feature flag is built-in). The feature flag relies on the app name, which in this case is observability.

We are checking the feature flag here:

kibana/x-pack/plugins/observability/public/utils/is_alert_details_enabled.ts

Line 42 in fa90a2f

if (isUnsafeAlertDetailsFlag(appNameFromAlertRuleType)) {