[Cases] Restrict searchFields, sortField and remove rootSearchFields from find_cases API #162245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-jankisalvi
added
release_note:breaking
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
30 tasks
adcoelho
reviewed
Jul 19, 2023
adcoelho
reviewed
Jul 19, 2023
js-jankisalvi
commented
Jul 20, 2023
cnasikas
reviewed
Jul 20, 2023
x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/find_cases.ts
Show resolved
Hide resolved
cnasikas
reviewed
Jul 20, 2023
| @@ -35,7 +35,6 @@ type FindOptions = Pick< | |||
| | 'searchFields' | |||
| | 'sortField' | |||
| | 'sortOrder' | |||
| | 'rootSearchFields' | |||
There was a problem hiding this comment.
I think this is needed because is used by SavedObjectFindOptionsKueryNode and the results of constructSearch is being passed to functions that use the SavedObjectFindOptionsKueryNode type.
There was a problem hiding this comment.
ohh, this common for all services and not only for find cases.
cnasikas
approved these changes
Jul 20, 2023
adcoelho
reviewed
Jul 20, 2023
| @@ -394,7 +394,7 @@ export default ({ getService }: FtrProviderContext): void => { | |||
| expect(cases.cases[0].title).to.equal(uuid); | |||
| }); | |||
|
|
|||
| it('should successfully find a case with a valid uuid in title', async () => { | |||
There was a problem hiding this comment.
why were these two tests with the same name not throwing a listing error!?
There was a problem hiding this comment.
no idea why 😆
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…from find_cases API (elastic#162245) ## Summary This PR modifies` find_cases API` with below changes - [x] Restrict `searchFields` only to the `title` and the `description` - [x] Restrict `sortField` to: `title`, `category`, `createdAt`, `updatedAt`, `status`, and `severity` - [x] Remove `rootSearchFields` ### Checklist Delete any items that are not applicable to this PR. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies
find_cases APIwith below changessearchFieldsonly to thetitleand thedescriptionsortFieldto:title,category,createdAt,updatedAt,status, andseverityrootSearchFieldsChecklist
Delete any items that are not applicable to this PR.
For maintainers