Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiling: update DEB/RPM deployment instructions #162157

Merged

Conversation

inge4pres
Copy link
Contributor

Summary

Update the confiuration file paths for DEB/RPM instructions in "Add Data" page, using the new values distributed in the packages.

Checklist

  • Documentation was added for features that require explanation or tutorials

For maintainers

@inge4pres inge4pres added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 18, 2023
@inge4pres inge4pres self-assigned this Jul 18, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@inge4pres inge4pres force-pushed the profiling/update-instructions-os-pkgs branch from 5a949e8 to b01fdc1 Compare July 25, 2023 13:21
@inge4pres inge4pres marked this pull request as ready for review July 27, 2023 08:59
@inge4pres inge4pres requested a review from a team as a code owner July 27, 2023 08:59
@inge4pres inge4pres force-pushed the profiling/update-instructions-os-pkgs branch from 7f667d3 to d411502 Compare July 27, 2023 08:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 297.1KB 297.2KB +44.0B

History

  • 💛 Build #144635 was flaky b01fdc1446092e933c8d8b1b3ba0d197ba986ee3
  • 💚 Build #143253 succeeded 5a949e8fbaf8ed10ef8a31325a438106892f53df

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @inge4pres

Copy link
Contributor

@jbcrail jbcrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jbcrail
Copy link
Contributor

jbcrail commented Jul 28, 2023

Is this meant for 8.9.1? I ask to make sure the appropriate labels are set. :)

@inge4pres
Copy link
Contributor Author

Is this meant for 8.9.1? I ask to make sure the appropriate labels are set. :)

Thanks for double-checking, no it isn't.
It is due for 8.10.

@inge4pres inge4pres merged commit 46d8346 into elastic:main Aug 1, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
## Summary

Update the configuration file paths for DEB/RPM instructions in "Add
Data" page, using the new values distributed in the packages.


Signed-off-by: inge4pres <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants