Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Hosts view test: fix apm services link #162147

Merged
merged 7 commits into from
Jul 19, 2023
Merged

[Infra UI] Hosts view test: fix apm services link #162147

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cd0d17
Remove some query params from apm service link check
jennypavlova Jul 18, 2023
e322493
Move to a separate describe block
jennypavlova Jul 18, 2023
f898849
Merge branch 'main' into 162051-fix-link-test-hosts-view
jennypavlova Jul 18, 2023
a1043fd
Unskip tests
jennypavlova Jul 18, 2023
2670523
Merge branch 'main' into 162051-fix-link-test-hosts-view
jennypavlova Jul 18, 2023
40193ee
Merge branch 'main' into 162051-fix-link-test-hosts-view
kibanamachine Jul 18, 2023
1c1976a
Merge branch 'main' into 162051-fix-link-test-hosts-view
kibanamachine Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions x-pack/test/functional/apps/infra/hosts_view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const returnTo = async (path: string, timeout = 2000) =>
retry.waitForWithTimeout('returned to hosts view', timeout, async () => {
await browser.goBack();
await pageObjects.header.waitUntilLoadingHasFinished();
const currentUrl = await browser.getCurrentUrl();
return !!currentUrl.match(path);
});
Expand Down Expand Up @@ -245,9 +246,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/162051
// FLAKY: https://github.com/elastic/kibana/issues/159368
describe.skip('#Single host Flyout', () => {
describe('#Single host Flyout', () => {
before(async () => {
await setHostViewEnabled(true);
await pageObjects.common.navigateToApp(HOSTS_VIEW_PATH);
Expand Down Expand Up @@ -385,22 +384,18 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});
});

it('should navigate to APM services after click', async () => {
await pageObjects.infraHostsView.clickFlyoutApmServicesLink();
const url = parse(await browser.getCurrentUrl());
describe('Flyout links', () => {
it('should navigate to APM services after click', async () => {
await pageObjects.infraHostsView.clickFlyoutApmServicesLink();
const url = parse(await browser.getCurrentUrl());
const query = decodeURIComponent(url.query ?? '');
const kuery = 'kuery=host.hostname:"Jennys-MBP.fritz.box"';

const query = decodeURIComponent(url.query ?? '');
expect(url.pathname).to.eql('/app/apm/services');
expect(query).to.contain(kuery);

const kuery = 'kuery=host.hostname:"Jennys-MBP.fritz.box"';
const rangeFrom = 'rangeFrom=2023-03-28T18:20:00.000Z';
const rangeTo = 'rangeTo=2023-03-28T18:21:00.000Z';

expect(url.pathname).to.eql('/app/apm/services');
expect(query).to.contain(kuery);
expect(query).to.contain(rangeFrom);
expect(query).to.contain(rangeTo);

await returnTo(HOSTS_VIEW_PATH);
await returnTo(HOSTS_VIEW_PATH);
});
});
});

Expand Down