[maps] support null description in saved object #162145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
nreese
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
jsanz
approved these changes
Jul 18, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 18, 2023
Part of elastic#162069 > This happens in maps too and possibly other SOs that have null description (not sure if it were ever possible to have null description in maps.) It seems from the SOs that Bhavya sent that it was possible for visualizations. With this schema change the bug if fixed elastic#162106 > Not sure if it makes sense to also do it in maps. @nreese wdyt? Add support for null description in maps saved object to be consistent with visualize saved objects. ### test instructions 1) Install web logs sample data set 2) export map 3) manually change ndjson, changing `description:""` to `description:null` 4) reimport map saved object 5) verify map can be opened --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit b222f7a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 18, 2023
) # Backport This will backport the following commits from `main` to `8.9`: - [[maps] support null description in saved object (#162145)](#162145) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-18T17:10:11Z","message":"[maps] support null description in saved object (#162145)\n\nPart of https://github.com/elastic/kibana/issues/162069\r\n\r\n> This happens in maps too and possibly other SOs that have null\r\ndescription (not sure if it were ever possible to have null description\r\nin maps.) It seems from the SOs that Bhavya sent that it was possible\r\nfor visualizations. With this schema change the bug if fixed\r\nhttps://github.com//pull/162106\r\n\r\n> Not sure if it makes sense to also do it in maps. @nreese wdyt?\r\n\r\nAdd support for null description in maps saved object to be consistent\r\nwith visualize saved objects.\r\n\r\n### test instructions\r\n1) Install web logs sample data set\r\n2) export map\r\n3) manually change ndjson, changing `description:\"\"` to\r\n`description:null`\r\n4) reimport map saved object\r\n5) verify map can be opened\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"b222f7a7d1d8a9e994a4f8293a56afa0b363c645","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","v8.10.0","v8.9.1"],"number":162145,"url":"https://github.com/elastic/kibana/pull/162145","mergeCommit":{"message":"[maps] support null description in saved object (#162145)\n\nPart of https://github.com/elastic/kibana/issues/162069\r\n\r\n> This happens in maps too and possibly other SOs that have null\r\ndescription (not sure if it were ever possible to have null description\r\nin maps.) It seems from the SOs that Bhavya sent that it was possible\r\nfor visualizations. With this schema change the bug if fixed\r\nhttps://github.com//pull/162106\r\n\r\n> Not sure if it makes sense to also do it in maps. @nreese wdyt?\r\n\r\nAdd support for null description in maps saved object to be consistent\r\nwith visualize saved objects.\r\n\r\n### test instructions\r\n1) Install web logs sample data set\r\n2) export map\r\n3) manually change ndjson, changing `description:\"\"` to\r\n`description:null`\r\n4) reimport map saved object\r\n5) verify map can be opened\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"b222f7a7d1d8a9e994a4f8293a56afa0b363c645"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162145","number":162145,"mergeCommit":{"message":"[maps] support null description in saved object (#162145)\n\nPart of https://github.com/elastic/kibana/issues/162069\r\n\r\n> This happens in maps too and possibly other SOs that have null\r\ndescription (not sure if it were ever possible to have null description\r\nin maps.) It seems from the SOs that Bhavya sent that it was possible\r\nfor visualizations. With this schema change the bug if fixed\r\nhttps://github.com//pull/162106\r\n\r\n> Not sure if it makes sense to also do it in maps. @nreese wdyt?\r\n\r\nAdd support for null description in maps saved object to be consistent\r\nwith visualize saved objects.\r\n\r\n### test instructions\r\n1) Install web logs sample data set\r\n2) export map\r\n3) manually change ndjson, changing `description:\"\"` to\r\n`description:null`\r\n4) reimport map saved object\r\n5) verify map can be opened\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"b222f7a7d1d8a9e994a4f8293a56afa0b363c645"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
Part of elastic#162069 > This happens in maps too and possibly other SOs that have null description (not sure if it were ever possible to have null description in maps.) It seems from the SOs that Bhavya sent that it was possible for visualizations. With this schema change the bug if fixed elastic#162106 > Not sure if it makes sense to also do it in maps. @nreese wdyt? Add support for null description in maps saved object to be consistent with visualize saved objects. ### test instructions 1) Install web logs sample data set 2) export map 3) manually change ndjson, changing `description:""` to `description:null` 4) reimport map saved object 5) verify map can be opened --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #162069
Add support for null description in maps saved object to be consistent with visualize saved objects.
test instructions
description:""todescription:null