Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Styling for embeddable #162134

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[SecuritySolution] Styling for embeddable #162134

merged 1 commit into from
Jul 18, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jul 18, 2023 •
edited
Loading

Summary

Metrics and histograms on Hosts, network, users, rules and alerts page are cropped.

Before:

Screenshot 2023-07-18 at 12 40 52

After:

Screenshot 2023-07-18 at 12 38 48

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience backport:skip This commit does not require backporting Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Feature:Lens Charts Security Solution Lens Charts feature v8.10.0 labels Jul 18, 2023
@angorayc angorayc self-assigned this Jul 18, 2023
@angorayc angorayc requested a review from a team as a code owner July 18, 2023 11:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@angorayc angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Jul 18, 2023
machadoum
machadoum reviewed Jul 18, 2023
View reviewed changes
...plugins/security_solution/public/common/components/visualization_actions/lens_embeddable.tsx
@@ -39,9 +39,13 @@ const LensComponentWrapper = styled.div<{
width: ${({ width }) => width ?? 'auto'};

${({ $addHoverActionsPadding }) =>
$addHoverActionsPadding
? `.embPanel__header--floater { top: ${HOVER_ACTIONS_PADDING * -1}px; }`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to embPanel__header--floater? I can't find it in the DOM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it's changed from Lens's side.

machadoum
machadoum approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test it locally and it looks good to me!

@angorayc angorayc enabled auto-merge (squash) July 18, 2023 12:37
@angorayc angorayc merged commit 2662400 into elastic:main Jul 18, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +184.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@angorayc
[SecuritySolution] Styling for embeddable (elastic#162134)
c2645a9 
## Summary


Metrics and histograms on Hosts, network, users, rules and alerts page
are cropped.


Before:

<img width="784" alt="Screenshot 2023-07-18 at 12 40 52"
src="https://github.com/elastic/kibana/assets/6295984/56ade48c-03dd-4095-a3e6-c87b2de895ad">



After:

<img width="766" alt="Screenshot 2023-07-18 at 12 38 48"
src="https://github.com/elastic/kibana/assets/6295984/e0c37138-e043-4075-8842-b7ace669d163">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum machadoum approved these changes

Assignees

@angorayc angorayc

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angorayc @elasticmachine @kibana-ci @machadoum